Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 1419703006: Don't propagate pagination struts to flow threads. (Closed)

Created:
5 years, 1 month ago by mstensho (USE GERRIT)
Modified:
5 years, 1 month ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't propagate pagination struts to flow threads. We'd lose the strut that way, since there's nobody to pick it up from a flow thread. R=leviw@chromium.org Committed: https://crrev.com/9b7b90be0fbe938d2b71f109772c11e41839bf51 Cr-Commit-Position: refs/heads/master@{#358195}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Capitalize ALL THE THINGS. Or at least the first word in each sentence. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/multicol/soft-break-before-first-child.html View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/multicol/soft-break-before-first-child-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
mstensho (USE GERRIT)
5 years, 1 month ago (2015-11-05 12:57:54 UTC) #1
mstensho (USE GERRIT)
¿Y éste, Señor leviw? (just in case you missed it - I have other patches ...
5 years, 1 month ago (2015-11-05 22:31:14 UTC) #2
leviw_travelin_and_unemployed
lgtm https://codereview.chromium.org/1419703006/diff/1/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp File third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp (right): https://codereview.chromium.org/1419703006/diff/1/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp#newcode2892 third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp:2892: // TODO(mstensho): if we're in a nested fragmentation ...
5 years, 1 month ago (2015-11-05 22:36:06 UTC) #3
mstensho (USE GERRIT)
Look at me spending kWhs of electricity! :) Thanks for reviewing. https://codereview.chromium.org/1419703006/diff/1/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp File third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp (right): ...
5 years, 1 month ago (2015-11-05 22:44:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419703006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419703006/20001
5 years, 1 month ago (2015-11-05 22:46:12 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-06 00:17:31 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 00:18:11 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9b7b90be0fbe938d2b71f109772c11e41839bf51
Cr-Commit-Position: refs/heads/master@{#358195}

Powered by Google App Engine
This is Rietveld 408576698