Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

Issue 1419703006: Don't propagate pagination struts to flow threads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Capitalize ALL THE THINGS. Or at least the first word in each sentence. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/multicol/soft-break-before-first-child-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
index e394118edb9f5e1d1721112df0aa43ff0bff9fd4..7c16f49b3df9fc2fc5124cc9c081350dc8a8d644 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
@@ -2887,6 +2887,14 @@ bool LayoutBlockFlow::allowsPaginationStrut() const
// TODO(mstensho): But we *should*.
if (isOutOfFlowPositioned())
return false;
+ if (isLayoutFlowThread()) {
+ // Don't let the strut escape the fragmentation context and get lost.
+ // TODO(mstensho): If we're in a nested fragmentation context, we should ideally convert
+ // and propagate the strut to the outer fragmentation context, so that the inner one is
+ // fully pushed to the next outer fragmentainer, instead of taking up unusable space in the
+ // previous one. But currently we have no mechanism in place to handle this.
+ return false;
+ }
LayoutBlock* containingBlock = this->containingBlock();
return containingBlock && containingBlock->isLayoutBlockFlow();
}
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/multicol/soft-break-before-first-child-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698