components/web_modal/web_contents_modal_dialog_manager_unittest.cc - Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_modal/web_contents_modal_dialog_manager_unittest.cc

Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: merge to head, address jyasskin's comments. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/browsing_data/browsing_data_appcache_helper_unittest.cc ('K') | « components/visitedlink/test/visitedlink_unittest.cc ('k') | content/browser/browser_thread_impl.h » ('j') | content/browser/browser_thread_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/web_modal/web_contents_modal_dialog_manager_unittest.cc

diff --git a/components/web_modal/web_contents_modal_dialog_manager_unittest.cc b/components/web_modal/web_contents_modal_dialog_manager_unittest.cc

index 613182bdb592f6d0d269181a20dfe519e40bab5e..5f01c147b6f6f5dc8c5d741ab2df620e37eb72a6 100644

--- a/components/web_modal/web_contents_modal_dialog_manager_unittest.cc

+++ b/components/web_modal/web_contents_modal_dialog_manager_unittest.cc

@@ -4,7 +4,6 @@

#include "components/web_modal/native_web_contents_modal_dialog_manager.h"

#include "components/web_modal/web_contents_modal_dialog_manager.h"

-#include "content/public/test/test_browser_thread.h"

#include "content/public/test/test_renderer_host.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -15,17 +14,10 @@ namespace web_modal {

class WebContentsModalDialogManagerTest

: public content::RenderViewHostTestHarness {

public:

- WebContentsModalDialogManagerTest()

- : ui_thread_(BrowserThread::UI, &message_loop_) {

- }

virtual void SetUp() {

content::RenderViewHostTestHarness::SetUp();

WebContentsModalDialogManager::CreateForWebContents(web_contents());

}

- private:

- content::TestBrowserThread ui_thread_;

};

class NativeWebContentsModalDialogManagerCloseTest