chrome/browser/browsing_data/browsing_data_appcache_helper_unittest.cc - Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/browsing_data_appcache_helper_unittest.cc

Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: merge to head, address jyasskin's comments. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/automation/automation_tab_helper_unittest.cc ('K') | « chrome/browser/automation/automation_tab_helper_unittest.cc ('k') | chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc » ('j') | content/browser/browser_thread_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/browsing_data_appcache_helper_unittest.cc

diff --git a/chrome/browser/browsing_data/browsing_data_appcache_helper_unittest.cc b/chrome/browser/browsing_data/browsing_data_appcache_helper_unittest.cc

index b138ac7c7717768c3193c36e456ecd3e2a4df3b5..c8213cde1635f71e14920492fbba0d6bb60e2f25 100644

--- a/chrome/browser/browsing_data/browsing_data_appcache_helper_unittest.cc

+++ b/chrome/browser/browsing_data/browsing_data_appcache_helper_unittest.cc

@@ -8,6 +8,7 @@

#include "base/bind_helpers.h"

#include "base/stl_util.h"

#include "chrome/test/base/testing_profile.h"

+#include "content/public/test/test_browser_thread_bundle.h"

#include "testing/gtest/include/gtest/gtest.h"

namespace {

@@ -29,7 +30,10 @@ class TestCompletionCallback {

} // namespace

-typedef testing::Test CannedBrowsingDataAppCacheHelperTest;

+class CannedBrowsingDataAppCacheHelperTest : public testing::Test {

+ private:

+ content::TestBrowserThreadBundle thread_bundle_;

jam 2013/05/31 17:29:25 why does this need it now?

awong 2013/05/31 20:57:17 Leaked in from the CL I split out out of. Next CL

+};

TEST_F(CannedBrowsingDataAppCacheHelperTest, SetInfo) {

TestingProfile profile;