Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4928)

Unified Diff: chrome/browser/automation/automation_tab_helper_unittest.cc

Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge to head, address jyasskin's comments. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/automation/automation_tab_helper_unittest.cc
diff --git a/chrome/browser/automation/automation_tab_helper_unittest.cc b/chrome/browser/automation/automation_tab_helper_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..49e7831d6c817a0eadd0fd96a40127ec2e6082ac
--- /dev/null
+++ b/chrome/browser/automation/automation_tab_helper_unittest.cc
@@ -0,0 +1,207 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
jam 2013/05/31 17:29:25 i think this is a merge conflict, this file is gon
awong 2013/05/31 20:57:17 Done.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <map>
+
+#include "base/basictypes.h"
+#include "chrome/browser/automation/automation_tab_helper.h"
+#include "chrome/browser/automation/mock_tab_event_observer.h"
+#include "chrome/test/base/chrome_render_view_host_test_harness.h"
+#include "content/public/test/test_browser_thread.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using content::BrowserThread;
+using testing::_;
+
+class AutomationTabHelperTest : public ChromeRenderViewHostTestHarness {
+ public:
+ virtual void SetUp() OVERRIDE {
+ ChromeRenderViewHostTestHarness::SetUp();
+ AutomationTabHelper::CreateForWebContents(web_contents());
+ mock_observer_.StartObserving(tab_helper());
+ }
+
+ protected:
+ // These are here so that we don't have to add each test as a
+ // |AutomationTabHelper| friend.
+ void StartLoading() {
+ tab_helper()->DidStartLoading(NULL);
+ }
+
+ void StopLoading() {
+ tab_helper()->DidStopLoading(NULL);
+ }
+
+ void WebContentsDestroyed() {
+ tab_helper()->WebContentsDestroyed(web_contents());
+ }
+
+ void WillPerformClientRedirect(int64 frame_id) {
+ tab_helper()->OnWillPerformClientRedirect(frame_id, 0);
+ }
+
+ void CompleteOrCancelClientRedirect(int64 frame_id) {
+ tab_helper()->OnDidCompleteOrCancelClientRedirect(frame_id);
+ }
+
+ AutomationTabHelper* tab_helper() {
+ return AutomationTabHelper::FromWebContents(web_contents());
+ }
+
+ MockTabEventObserver mock_observer_;
+};
+
+ACTION_P2(CheckHasPendingLoads, tab_helper, has_pending_loads) {
+ EXPECT_EQ(has_pending_loads, tab_helper->has_pending_loads());
+}
+
+TEST_F(AutomationTabHelperTest, AddAndRemoveObserver) {
+ testing::MockFunction<void()> check;
+
+ {
+ testing::InSequence expect_in_sequence;
+ EXPECT_CALL(mock_observer_, OnFirstPendingLoad(_));
+ EXPECT_CALL(check, Call());
+ }
+
+ StartLoading();
+ check.Call();
+ tab_helper()->RemoveObserver(&mock_observer_);
+ StartLoading();
+}
+
+TEST_F(AutomationTabHelperTest, StartStopLoading) {
+ testing::MockFunction<void()> check;
+
+ testing::InSequence expect_in_sequence;
+ EXPECT_CALL(mock_observer_, OnFirstPendingLoad(web_contents()))
+ .WillOnce(CheckHasPendingLoads(tab_helper(), true));
+ EXPECT_CALL(check, Call());
+ EXPECT_CALL(mock_observer_, OnNoMorePendingLoads(web_contents()))
+ .WillOnce(CheckHasPendingLoads(tab_helper(), false));
+
+ EXPECT_FALSE(tab_helper()->has_pending_loads());
+ StartLoading();
+ EXPECT_TRUE(tab_helper()->has_pending_loads());
+ check.Call();
+ StopLoading();
+ EXPECT_FALSE(tab_helper()->has_pending_loads());
+}
+
+TEST_F(AutomationTabHelperTest, DuplicateLoads) {
+ testing::InSequence expect_in_sequence;
+ EXPECT_CALL(mock_observer_, OnFirstPendingLoad(web_contents()));
+ EXPECT_CALL(mock_observer_, OnNoMorePendingLoads(web_contents()));
+
+ StartLoading();
+ StartLoading();
+ StopLoading();
+ StopLoading();
+}
+
+TEST_F(AutomationTabHelperTest, ClientRedirect) {
+ testing::MockFunction<void()> check;
+
+ testing::InSequence expect_in_sequence;
+ EXPECT_CALL(mock_observer_, OnFirstPendingLoad(web_contents()))
+ .WillOnce(CheckHasPendingLoads(tab_helper(), true));
+ EXPECT_CALL(check, Call());
+ EXPECT_CALL(mock_observer_, OnNoMorePendingLoads(web_contents()))
+ .WillOnce(CheckHasPendingLoads(tab_helper(), false));
+
+ WillPerformClientRedirect(1);
+ EXPECT_TRUE(tab_helper()->has_pending_loads());
+ check.Call();
+ CompleteOrCancelClientRedirect(1);
+ EXPECT_FALSE(tab_helper()->has_pending_loads());
+}
+
+TEST_F(AutomationTabHelperTest, DiscardExtraClientRedirects) {
+ EXPECT_CALL(mock_observer_, OnFirstPendingLoad(web_contents()));
+ EXPECT_CALL(mock_observer_, OnNoMorePendingLoads(web_contents()));
+
+ WillPerformClientRedirect(1);
+ WillPerformClientRedirect(1);
+ CompleteOrCancelClientRedirect(1);
+ EXPECT_FALSE(tab_helper()->has_pending_loads());
+ CompleteOrCancelClientRedirect(1);
+ CompleteOrCancelClientRedirect(2);
+}
+
+TEST_F(AutomationTabHelperTest, StartStopLoadingWithClientRedirect) {
+ testing::MockFunction<void()> check;
+
+ testing::InSequence expect_in_sequence;
+ EXPECT_CALL(mock_observer_, OnFirstPendingLoad(web_contents()));
+ EXPECT_CALL(mock_observer_, OnNoMorePendingLoads(web_contents()));
+
+ StartLoading();
+ WillPerformClientRedirect(1);
+ CompleteOrCancelClientRedirect(1);
+ StopLoading();
+}
+
+TEST_F(AutomationTabHelperTest, ClientRedirectBeforeLoad) {
+ testing::MockFunction<void()> check;
+
+ testing::InSequence expect_in_sequence;
+ EXPECT_CALL(mock_observer_, OnFirstPendingLoad(web_contents()));
+ EXPECT_CALL(check, Call());
+ EXPECT_CALL(mock_observer_, OnNoMorePendingLoads(web_contents()));
+
+ StartLoading();
+ WillPerformClientRedirect(1);
+ CompleteOrCancelClientRedirect(1);
+ EXPECT_TRUE(tab_helper()->has_pending_loads());
+ check.Call();
+ StopLoading();
+}
+
+TEST_F(AutomationTabHelperTest, ClientRedirectAfterLoad) {
+ testing::MockFunction<void()> check;
+
+ testing::InSequence expect_in_sequence;
+ EXPECT_CALL(mock_observer_, OnFirstPendingLoad(web_contents()));
+ EXPECT_CALL(check, Call());
+ EXPECT_CALL(mock_observer_, OnNoMorePendingLoads(web_contents()));
+
+ StartLoading();
+ WillPerformClientRedirect(1);
+ StopLoading();
+ EXPECT_TRUE(tab_helper()->has_pending_loads());
+ check.Call();
+ CompleteOrCancelClientRedirect(1);
+ EXPECT_FALSE(tab_helper()->has_pending_loads());
+}
+
+TEST_F(AutomationTabHelperTest, AllFramesMustFinishRedirects) {
+ testing::MockFunction<void()> check;
+
+ testing::InSequence expect_in_sequence;
+ EXPECT_CALL(mock_observer_, OnFirstPendingLoad(web_contents()));
+ EXPECT_CALL(check, Call());
+ EXPECT_CALL(mock_observer_, OnNoMorePendingLoads(web_contents()));
+
+ WillPerformClientRedirect(1);
+ WillPerformClientRedirect(2);
+ CompleteOrCancelClientRedirect(1);
+ check.Call();
+ EXPECT_TRUE(tab_helper()->has_pending_loads());
+ CompleteOrCancelClientRedirect(2);
+ EXPECT_FALSE(tab_helper()->has_pending_loads());
+}
+
+TEST_F(AutomationTabHelperTest, DestroyedTabStopsLoading) {
+ testing::MockFunction<void()> check;
+
+ testing::InSequence expect_in_sequence;
+ EXPECT_CALL(mock_observer_, OnFirstPendingLoad(web_contents()));
+ EXPECT_CALL(mock_observer_, OnNoMorePendingLoads(web_contents()));
+
+ StartLoading();
+ WillPerformClientRedirect(1);
+ WebContentsDestroyed();
+ EXPECT_FALSE(tab_helper()->has_pending_loads());
+}

Powered by Google App Engine
This is Rietveld 408576698