content/browser/browser_thread_impl.h - Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_thread_impl.h

Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: platform specific dchecks should be platform specific Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/web_modal/web_contents_modal_dialog_manager_unittest.cc ('k') | content/browser/browser_thread_impl.cc » ('j') | content/public/test/test_browser_thread_bundle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_thread_impl.h

diff --git a/content/browser/browser_thread_impl.h b/content/browser/browser_thread_impl.h

index b4ca49b027a76f1c8c62e99f7f12d6bf2698cb2a..17263452b83307db9253995b98a63308b0dfede7 100644

--- a/content/browser/browser_thread_impl.h

+++ b/content/browser/browser_thread_impl.h

@@ -18,8 +18,9 @@ class CONTENT_EXPORT BrowserThreadImpl : public BrowserThread,

// to construct a BrowserThreadImpl that already exists.

explicit BrowserThreadImpl(BrowserThread::ID identifier);

- // Special constructor for the main (UI) thread and unittests. We use a dummy

- // thread here since the main thread already exists.

+ // Special constructor for the main (UI) thread and unittests. If a

+ // |message_loop| is provied, we use a dummy thread here since the main

+ // thread already exists.

BrowserThreadImpl(BrowserThread::ID identifier,

base::MessageLoop* message_loop);

virtual ~BrowserThreadImpl();