content/browser/browser_thread_impl.cc - Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_thread_impl.cc

Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: platform specific dchecks should be platform specific Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/browser_thread_impl.h ('k') | content/browser/devtools/devtools_manager_unittest.cc » ('j') | content/public/test/test_browser_thread_bundle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_thread_impl.cc

diff --git a/content/browser/browser_thread_impl.cc b/content/browser/browser_thread_impl.cc

index 37f67bc191a1c1fb933932c053bfe82f84e8745e..97c0387e4a5d73d70d3e05cae64a13a7188f6d7e 100644

--- a/content/browser/browser_thread_impl.cc

+++ b/content/browser/browser_thread_impl.cc

@@ -70,8 +70,11 @@ BrowserThreadImpl::BrowserThreadImpl(ID identifier)

BrowserThreadImpl::BrowserThreadImpl(ID identifier,

base::MessageLoop* message_loop)

- : Thread(message_loop->thread_name().c_str()), identifier_(identifier) {

- set_message_loop(message_loop);

+ : Thread(message_loop ? message_loop->thread_name().c_str() :

+ g_browser_thread_names[identifier]),

+ identifier_(identifier) {

+ if (message_loop)

+ set_message_loop(message_loop);

Initialize();

}