Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1419673008: Revert of Switch Chrome Android using v8 arch specific external data name (Closed)

Created:
5 years, 2 months ago by DaleCurtis
Modified:
5 years, 2 months ago
CC:
blink-reviews, cbentzel+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, gunsch+watch_chromium.org, halliwell+watch_chromium.org, jam, jbudorick+watch_chromium.org, jochen+watch_chromium.org, klundberg+watch_chromium.org, lcwu+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Switch Chrome Android using v8 arch specific external data name (patchset #5 id:80001 of https://codereview.chromium.org/1400953002/ ) Reason for revert: Looks to have broken various Android Mojo tests: http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20GN&number=31621 http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20GN&number=31622 Original issue's description: > Switch Chrome Android using v8 arch specific external data name > > For 32-bit, natives_blob_32.bin and snapshot_blob_32.bin are used. > For 64-bit, natives_blob_64.bin and natives_blob_64.bin are used. > > This patch also removed the existing v8 startup data in > destination directory by using copy_ex to remove directory > first. > > BUG=540788 > > Committed: https://crrev.com/979b03a19f63b1cbe02fa3df99707c3f93f7c9cf > Cr-Commit-Position: refs/heads/master@{#355680} TBR=jochen@chromium.org,dpranke@chromium.org,halliwell@chromium.org,jbudorick@chromium.org,mef@chromium.org,rmcilroy@chromium.org,dtrainor@chromium.org,cpu@chromium.org,jam@chromium.org,michaelbai@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=540788 Committed: https://crrev.com/c2574ed2dede52cbf0353a3aca99d96cf0794571 Cr-Commit-Position: refs/heads/master@{#355697}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -214 lines) Patch
D build/android/v8_external_startup_data_arch_suffix.gypi View 1 chunk +0 lines, -18 lines 0 comments Download
M build_overrides/v8.gni View 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/android/BUILD.gn View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/chrome_android_paks.gypi View 3 chunks +6 lines, -15 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +4 lines, -11 lines 0 comments Download
M chromecast/chromecast.gyp View 1 chunk +4 lines, -15 lines 0 comments Download
M components/components_tests.gyp View 2 chunks +13 lines, -22 lines 0 comments Download
M content/content.gyp View 1 chunk +30 lines, -28 lines 0 comments Download
M content/content_shell.gypi View 4 chunks +15 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 5 chunks +17 lines, -22 lines 0 comments Download
M content/shell/android/BUILD.gn View 2 chunks +5 lines, -5 lines 0 comments Download
M gin/v8_initializer.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M net/net.gyp View 2 chunks +12 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform_tests.gyp View 2 chunks +12 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/web/web_tests.gyp View 2 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
DaleCurtis
Created Revert of Switch Chrome Android using v8 arch specific external data name
5 years, 2 months ago (2015-10-23 01:05:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419673008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419673008/1
5 years, 2 months ago (2015-10-23 01:05:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 01:07:10 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 01:08:11 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2574ed2dede52cbf0353a3aca99d96cf0794571
Cr-Commit-Position: refs/heads/master@{#355697}

Powered by Google App Engine
This is Rietveld 408576698