content/shell/android/BUILD.gn - Issue 1419673008: Revert of Switch Chrome Android using v8 arch specific external data name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/android/BUILD.gn

Issue 1419673008: Revert of Switch Chrome Android using v8 arch specific external data name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/shell/android/BUILD.gn

diff --git a/content/shell/android/BUILD.gn b/content/shell/android/BUILD.gn

index 94e0d9f2199fb61f8451a9232c92a39fb842124f..6aa412310d8bbb90624635387b711f85f0420618 100644

--- a/content/shell/android/BUILD.gn

+++ b/content/shell/android/BUILD.gn

@@ -102,8 +102,10 @@

deps += [ "//third_party/icu:icudata" ]

}

if (v8_use_external_startup_data) {

- renaming_sources = v8_external_startup_data_renaming_sources

- renaming_destinations = v8_external_startup_data_renaming_destinations

+ sources += [

+ "$root_build_dir/natives_blob.bin",

+ "$root_build_dir/snapshot_blob.bin",

+ ]

deps += [ "//v8" ]

}

@@ -157,9 +159,7 @@

"//base:base_javatests",

"//net/android:net_javatests",

]

- data_deps = [

- ":content_shell_apk",

- ]

+ data_deps = [ ":content_shell_apk" ]

apk_under_test = ":content_shell_apk"

apk_name = "ContentShellTest"

android_manifest = "javatests/AndroidManifest.xml"

« no previous file with comments | « content/content_tests.gypi ('k') | gin/v8_initializer.cc » ('j') | no next file with comments »