Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1419643002: Ignore compile_targets returned by analyze and rely completely on matching_exes (Closed)

Created:
5 years, 2 months ago by Paweł Hajdan Jr.
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke, sky
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Ignore compile_targets returned by analyze and rely completely on matching_exes compile_targets was designed for builders that compile 'all', which is no longer the case. BUG=544571

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -25 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/api.py View 3 chunks +5 lines, -2 lines 2 comments Download
M scripts/slave/recipes/chromium_gn.expected/compile_failure.json View 1 chunk +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_tryserver_v8_v8_android_chromium_gn_dbg.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_tryserver_v8_v8_linux_chromium_gn_rel.json View 1 chunk +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/no_tests_run.json View 1 chunk +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/use_v8_patch_on_chromium_gn_trybot.json View 1 chunk +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.py View 2 chunks +3 lines, -14 lines 2 comments Download
M scripts/slave/recipes/chromium_trybot.expected/analyze_runs_only_angle_unittests.json View 3 chunks +6 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/clobber_analyze.json View 2 chunks +3 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json View 2 chunks +5 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets_exclude_all.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests_no_builder.json View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/gpu_tests.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_time_out_is_handled_correctly.json View 3 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/telemetry_gpu_harness_failure.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/telemetry_gpu_no_results.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/telemetry_gpu_no_summary.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/telemetry_gpu_swarming_error.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/telemetry_gpu_with_results_but_bad_exit_code.json View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Dirk Pranke
https://codereview.chromium.org/1419643002/diff/1/scripts/slave/recipe_modules/chromium_tests/api.py File scripts/slave/recipe_modules/chromium_tests/api.py (right): https://codereview.chromium.org/1419643002/diff/1/scripts/slave/recipe_modules/chromium_tests/api.py#newcode632 scripts/slave/recipe_modules/chromium_tests/api.py:632: matching_exes = self.m.filter.matching_exes Why keep both compile_targets and matching_exes? ...
5 years, 2 months ago (2015-10-20 20:08:31 UTC) #2
Dirk Pranke
(sigh, hit send too soon ...) https://codereview.chromium.org/1419643002/diff/1/scripts/slave/recipe_modules/chromium_tests/api.py File scripts/slave/recipe_modules/chromium_tests/api.py (right): https://codereview.chromium.org/1419643002/diff/1/scripts/slave/recipe_modules/chromium_tests/api.py#newcode632 scripts/slave/recipe_modules/chromium_tests/api.py:632: matching_exes = self.m.filter.matching_exes ...
5 years, 2 months ago (2015-10-20 20:10:06 UTC) #3
sky
https://codereview.chromium.org/1419643002/diff/1/scripts/slave/recipes/chromium_trybot.py File scripts/slave/recipes/chromium_trybot.py (right): https://codereview.chromium.org/1419643002/diff/1/scripts/slave/recipes/chromium_trybot.py#newcode741 scripts/slave/recipes/chromium_trybot.py:741: api.chromium_tests.analyze( On 2015/10/20 20:10:06, Dirk Pranke wrote: > why ...
5 years, 2 months ago (2015-10-21 16:16:13 UTC) #4
Dirk Pranke
4 years, 3 months ago (2016-08-31 18:53:56 UTC) #6
Message was sent while issue was closed. 
Closing, I think we ended up handling this differently.

Powered by Google App Engine
This is Rietveld 408576698