scripts/slave/recipes/chromium_gn.expected/use_v8_patch_on_chromium_gn_trybot.json - Issue 1419643002: Ignore compile_targets returned by analyze and rely completely on matching_exes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_gn.expected/use_v8_patch_on_chromium_gn_trybot.json

Issue 1419643002: Ignore compile_targets returned by analyze and rely completely on matching_exes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipe_modules/chromium_tests/api.py ('K') | « scripts/slave/recipes/chromium_gn.expected/no_tests_run.json ('k') | scripts/slave/recipes/chromium_trybot.py » ('j') | scripts/slave/recipes/chromium_trybot.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium_gn.expected/use_v8_patch_on_chromium_gn_trybot.json

diff --git a/scripts/slave/recipes/chromium_gn.expected/use_v8_patch_on_chromium_gn_trybot.json b/scripts/slave/recipes/chromium_gn.expected/use_v8_patch_on_chromium_gn_trybot.json

index 610d5d04bb9a11f68615e5192d4db9e0083b57ae..b6b4078c365dcbdb442e17c05125fd40c9fadd3f 100644

--- a/scripts/slave/recipes/chromium_gn.expected/use_v8_patch_on_chromium_gn_trybot.json

+++ b/scripts/slave/recipes/chromium_gn.expected/use_v8_patch_on_chromium_gn_trybot.json

@@ -228,6 +228,9 @@

"@@@STEP_LOG_LINE@analyze_details@ \"compile_targets\": [@@@",

"@@@STEP_LOG_LINE@analyze_details@ \"base_unittests\"@@@",

"@@@STEP_LOG_LINE@analyze_details@ ], @@@",

+ "@@@STEP_LOG_LINE@analyze_details@ \"matching_exes\": [@@@",

+ "@@@STEP_LOG_LINE@analyze_details@ \"base_unittests\"@@@",

+ "@@@STEP_LOG_LINE@analyze_details@ ], @@@",

"@@@STEP_LOG_LINE@analyze_details@ \"original_compile_targets\": [@@@",

"@@@STEP_LOG_LINE@analyze_details@ \"base_unittests\", @@@",

"@@@STEP_LOG_LINE@analyze_details@ \"all\"@@@",