Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 1419623002: [turbofan] Stage --turbo-inlining behind --turbo flag. (Closed)

Created:
5 years, 2 months ago by Benedikt Meurer
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@1415733003
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Stage --turbo-inlining behind --turbo flag. This stages the general purpose inlining mechanism in TurboFan and also disables the remaining tests that still fail. We do this to get test coverage early and to avoid regressing inlining as we go along. R=jarin@chromium.org,mstarzinger@chromium.org BUG=v8:4493 LOG=n Committed: https://crrev.com/d5847622f9f05e8cedcc3b0a050ac423ad9ceeed Cr-Commit-Position: refs/heads/master@{#31406}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M src/flag-definitions.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (2 generated)
Benedikt Meurer
5 years, 2 months ago (2015-10-20 10:29:30 UTC) #1
Benedikt Meurer
Next try staging this beast... PTAL
5 years, 2 months ago (2015-10-20 10:29:56 UTC) #2
Jarin
LGTM with a nit. https://codereview.chromium.org/1419623002/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/1419623002/diff/1/src/flag-definitions.h#newcode415 src/flag-definitions.h:415: DEFINE_IMPLICATION(turbo, turbo_asm_deoptimization) Could you remove ...
5 years, 2 months ago (2015-10-20 10:31:03 UTC) #3
Michael Starzinger
LGTM. https://codereview.chromium.org/1419623002/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/1419623002/diff/1/src/flag-definitions.h#newcode415 src/flag-definitions.h:415: DEFINE_IMPLICATION(turbo, turbo_asm_deoptimization) On 2015/10/20 10:31:03, Jarin wrote: > ...
5 years, 2 months ago (2015-10-20 10:32:09 UTC) #4
Benedikt Meurer
https://codereview.chromium.org/1419623002/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/1419623002/diff/1/src/flag-definitions.h#newcode415 src/flag-definitions.h:415: DEFINE_IMPLICATION(turbo, turbo_asm_deoptimization) On 2015/10/20 10:32:09, Michael Starzinger wrote: > ...
5 years, 2 months ago (2015-10-20 10:32:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419623002/20001
5 years, 2 months ago (2015-10-20 10:32:58 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-20 10:56:56 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 10:57:08 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d5847622f9f05e8cedcc3b0a050ac423ad9ceeed
Cr-Commit-Position: refs/heads/master@{#31406}

Powered by Google App Engine
This is Rietveld 408576698