Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1415733003: [turbofan] Fix invalid lowering of let variable in TDZ. (Closed)

Created:
5 years, 2 months ago by Michael Starzinger
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_inlining-heuristic-6
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix invalid lowering of let variable in TDZ. This fixes JSNativeContextSpecialization to not lower JSLoadGlobal and JSStoreGlobal nodes if the global variable has morphed into a context variable that is currently within a TDZ. Scary variable binding is being scary! R=bmeurer@chromium.org TEST=cctest/test-decls/Regress3941 --turbo-filter="f" BUG=v8:4470 LOG=n Committed: https://crrev.com/4de969cebe8288a96b77e319f4fce113c979b5d7 Cr-Commit-Position: refs/heads/master@{#31405}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/compiler/js-native-context-specialization.cc View 3 chunks +2 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years, 2 months ago (2015-10-20 09:41:21 UTC) #1
Benedikt Meurer
LGTM, thanks!
5 years, 2 months ago (2015-10-20 09:42:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415733003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415733003/20001
5 years, 2 months ago (2015-10-20 10:32:18 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-20 10:37:30 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 10:37:52 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4de969cebe8288a96b77e319f4fce113c979b5d7
Cr-Commit-Position: refs/heads/master@{#31405}

Powered by Google App Engine
This is Rietveld 408576698