Use default theme resource for aura on Android

Use default theme resource for aura on Android

Aura on Android does not depend on ash, so use default theme resource if
we build for Android.

BUG=507792
Committed: https://crrev.com/7a7532caede62f0fa0bd77b4d73c2ea2348466fe
Cr-Commit-Position: refs/heads/master@{#355782}

[bshe, 2015-10-22 18:54:37]

Description was changed from

==========
Use default theme resource for aura on Android

Aura on Android do not depend on ash, so use default theme resource if
we build for Android.

BUG=507792
==========

to

==========
Use default theme resource for aura on Android

Aura on Android does not depend on ash, so use default theme resource if
we build for Android.

BUG=507792
==========

[bshe, 2015-10-22 18:55:25]

bshe@chromium.org changed reviewers:
+ sky@chromium.org

[bshe, 2015-10-22 18:55:25]

Hi Scott. Do you mind to take a look at this CL? It is part of upstream aura on
Android effort. Thanks!

[sky, 2015-10-22 23:00:17]

LGTM

https://codereview.chromium.org/1419583006/diff/1/chrome/browser/ui/views/the...
File chrome/browser/ui/views/theme_image_mapper.cc (right):

https://codereview.chromium.org/1419583006/diff/1/chrome/browser/ui/views/the...
chrome/browser/ui/views/theme_image_mapper.cc:40: #endif  //
!defined(OS_CHROMEOS)
nit: update this (I would just nuke the comment, I'm personally not a fan of
them for cases like this and as you can see they easily get out of date).

[bshe, 2015-10-23 13:47:58]

Thanks for review!

https://codereview.chromium.org/1419583006/diff/1/chrome/browser/ui/views/the...
File chrome/browser/ui/views/theme_image_mapper.cc (right):

https://codereview.chromium.org/1419583006/diff/1/chrome/browser/ui/views/the...
chrome/browser/ui/views/theme_image_mapper.cc:40: #endif  //
!defined(OS_CHROMEOS)
On 2015/10/22 23:00:17, sky wrote:
> nit: update this (I would just nuke the comment, I'm personally not a fan of
> them for cases like this and as you can see they easily get out of date).

Done.

[bshe, 2015-10-23 13:48:02]

The CQ bit was checked by bshe@chromium.org

[bshe, 2015-10-23 13:48:02]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1419583006/#ps20001
(title: "remove comment")

[commit-bot: I haz the power, 2015-10-23 13:48:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419583006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419583006/20001

[commit-bot: I haz the power, 2015-10-23 15:03:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-23 15:03:49]

Patchset 2 (id:??) landed as
https://crrev.com/7a7532caede62f0fa0bd77b4d73c2ea2348466fe
Cr-Commit-Position: refs/heads/master@{#355782}

[mfomitchev, 2016-01-15 01:41:19]

Hey Biao, any reason we wouldn't revert this?

[bshe, 2016-01-15 15:38:35]

On 2016/01/15 01:41:19, mfomitchev wrote:
> Hey Biao, any reason we wouldn't revert this?

I believe I have reverted it here: https://codereview.chromium.org/1562803002/
Well, it is not exactly a revert as I also kept a change that worth keeping.
That's
probably why the revert didnt show up here.