Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 1419553003: Revert "Introduce support design library to chrome and roll android_tools/" (Closed)

Created:
5 years, 1 month ago by aurimas (slooooooooow)
Modified:
5 years, 1 month ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, mikecase+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Introduce support design library to chrome and roll android_tools/" This reverts https://codereview.chromium.org/1225393002. Android Support design library is large and currently is only used in one place where we already have an existing similar class. This will reduce our method limit by 1409 BUG=272790 Committed: https://crrev.com/eca9cefb72e6bf039ce9b72921f011459ea4ccf2 Cr-Commit-Position: refs/heads/master@{#356982}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Proper rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -28 lines) Patch
M build/secondary/third_party/android_tools/BUILD.gn View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/res/layout/eb_edit.xml View 3 chunks +4 lines, -7 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M tools/android/eclipse/.classpath View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 30 (13 generated)
aurimas (slooooooooow)
PTAL
5 years, 1 month ago (2015-10-29 16:23:30 UTC) #2
aurimas (slooooooooow)
yfriedman is OOO, adding tedchoc@
5 years, 1 month ago (2015-10-29 16:41:36 UTC) #4
Ted C
lgtm
5 years, 1 month ago (2015-10-29 16:45:35 UTC) #5
aurimas (slooooooooow)
+thestig: for chrome/chrome.gyp +jbudorick for build/*
5 years, 1 month ago (2015-10-29 16:57:02 UTC) #7
Ian Wen
lgtm. Be sure to change third_party/android_tools as well.
5 years, 1 month ago (2015-10-29 16:57:36 UTC) #9
Yaron
lgtm - thanks
5 years, 1 month ago (2015-10-29 17:04:27 UTC) #10
aurimas (slooooooooow)
Actually CC these guys: +thestig: for chrome/chrome.gyp +jbudorick for build/*
5 years, 1 month ago (2015-10-29 17:18:48 UTC) #12
Lei Zhang
On 2015/10/29 16:57:02, aurimas wrote: > +thestig: for chrome/chrome.gyp lgtm
5 years, 1 month ago (2015-10-29 17:19:53 UTC) #13
jbudorick
build/ lgtm
5 years, 1 month ago (2015-10-29 18:52:57 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419553003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419553003/1
5 years, 1 month ago (2015-10-29 20:09:01 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/115961) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 1 month ago (2015-10-29 20:11:46 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419553003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419553003/20001
5 years, 1 month ago (2015-10-29 21:27:54 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419553003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419553003/40001
5 years, 1 month ago (2015-10-29 21:53:28 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/123981)
5 years, 1 month ago (2015-10-29 23:06:41 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419553003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419553003/40001
5 years, 1 month ago (2015-10-29 23:11:11 UTC) #28
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-10-29 23:38:15 UTC) #29
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 23:39:11 UTC) #30
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/eca9cefb72e6bf039ce9b72921f011459ea4ccf2
Cr-Commit-Position: refs/heads/master@{#356982}

Powered by Google App Engine
This is Rietveld 408576698