Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1419503008: TBR: bug fixes for switch from [] to JsNative.SetProperty Make calls to .isExternal property more r… (Closed)

Created:
5 years, 1 month ago by Jacob
Modified:
5 years, 1 month ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

TBR: bug fixes for switch from [] to JsNative.SetProperty Make calls to .isExternal property more robust BUG= Committed: https://github.com/dart-lang/sdk/commit/2c6989df5fe752a20fd0ca5b930f4b29a8d7c633

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M sdk/lib/js/dartium/js_dartium.dart View 3 chunks +11 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jacob
that was some horrible logic you approved in my cl earlier today :) The logic ...
5 years, 1 month ago (2015-11-05 01:46:58 UTC) #2
Jacob
Committed patchset #1 (id:1) manually as 2c6989df5fe752a20fd0ca5b930f4b29a8d7c633 (presubmit successful).
5 years, 1 month ago (2015-11-05 01:47:08 UTC) #3
Alan Knight
5 years, 1 month ago (2015-11-05 21:14:05 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698