TBR: bug fixes for switch from [] to JsNative.SetProperty Make calls to .isExternal property more r…

sdk/lib/js/dartium/js_dartium.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Support for interoperating with JavaScript.
  *
  * This library provides access to JavaScript objects from Dart, allowing
  * Dart code to get and set properties, and call methods of JavaScript objects
  * and invoke JavaScript functions. The library takes care of converting
@@ skipping 292 matching lines @@
   if (declaration is mirrors.MethodMirror && declaration.isSetter) {
     assert(name.endsWith("="));
     name = name.substring(0, name.length - 1);
   }
   return name;
 }
 
 final _JS_LIBRARY_PREFIX = "js_library";
 final _UNDEFINED_VAR = "_UNDEFINED_JS_CONST";
 
-String _accessJsPath(String path) {
-  var parts = path.split(".");
+String _accessJsPath(String path) => _accessJsPathHelper(path.split("."));
+
+String _accessJsPathHelper(Iterable<String> parts) {
   var sb = new StringBuffer();
   sb
     ..write('${_JS_LIBRARY_PREFIX}.JsNative.getProperty(' * parts.length)
     ..write("${_JS_LIBRARY_PREFIX}.context");
   for (var p in parts) {
     sb.write(", '$p')");
   }
   return sb.toString();
 }
 
-
 String _accessJsPathSetter(String path) {
   var parts = path.split(".");
-  return "${_JS_LIBRARY_PREFIX}.JsNative.setProperty(${_accessJsPath(parts.getRange(0, parts.length - 1).join('.'))
-      }, '{parts.end}', v)";
+  return "${_JS_LIBRARY_PREFIX}.JsNative.setProperty(${_accessJsPathHelper(parts.getRange(0, parts.length - 1))
+      }, '${parts.last}', v)";
 }
 
 @Deprecated("Internal Use Only")
 void addMemberHelper(
     mirrors.MethodMirror declaration, String path, StringBuffer sb,
     {bool isStatic: false, String memberName}) {
   if (!declaration.isConstructor) {
     var jsName = _getJsMemberName(declaration);
     path = (path != null && path.isNotEmpty) ? "${path}.${jsName}" : jsName;
   }
@@ skipping 48 matching lines @@
       ..write("[${args.join(",")}]");
 
     if (hasOptional) {
       sb.write(".takeWhile((i) => i != ${_UNDEFINED_VAR}).toList()");
     }
     sb.write("));");
   }
   sb.write("\n");
 }
 
-// TODO(jacobr): make this check more robust.
-bool _isExternal(mirrors.Mirror mirror) {
-  /*
-  var source = mirror.source;
-  return source != null && source.startsWith("external ");
-  */
-  return mirror.isExternal;
+bool _isExternal(mirrors.MethodMirror mirror) {
+  // This try-catch block is a workaround for BUG:24834.
+  try {
+    return mirror.isExternal;
+  } catch (e) { }
+  return false;
 }
 
 List<String> _generateExternalMethods() {
   var staticCodegen = <String>[];
   mirrors.currentMirrorSystem().libraries.forEach((uri, library) {
     var sb = new StringBuffer();
     String jsLibraryName = _getJsName(library);
     library.declarations.forEach((name, declaration) {
       if (declaration is mirrors.MethodMirror) {
         if ((_hasJsName(declaration) || jsLibraryName != null) &&
@@ skipping 985 matching lines @@
     return f;
   } else {
     var ret = _interopCaptureThisExpando[f];
     if (ret == null) {
       ret = new JsFunction.withThis(f);
       _interopCaptureThisExpando[f] = ret;
     }
     return ret;
   }
 }