Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 1419503002: refactor timing tests to not use the test framework (Closed)

Created:
5 years, 2 months ago by keertip
Modified:
5 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : remove unused code #

Total comments: 2

Patch Set 3 : remove unused code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -46 lines) Patch
M pkg/analysis_server/benchmark/perf/analysis_timing_tests.dart View 1 2 7 chunks +34 lines, -25 lines 0 comments Download
M pkg/analysis_server/benchmark/perf/completion_timing_tests.dart View 1 2 5 chunks +17 lines, -19 lines 0 comments Download
M pkg/analysis_server/benchmark/perf/performance_tests.dart View 1 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
keertip
5 years, 2 months ago (2015-10-19 21:49:44 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/1419503002/diff/20001/pkg/analysis_server/benchmark/perf/analysis_timing_tests.dart File pkg/analysis_server/benchmark/perf/analysis_timing_tests.dart (right): https://codereview.chromium.org/1419503002/diff/20001/pkg/analysis_server/benchmark/perf/analysis_timing_tests.dart#newcode78 pkg/analysis_server/benchmark/perf/analysis_timing_tests.dart:78: stopwatch.reset(); Does 'reset' also stop the clock? If ...
5 years, 2 months ago (2015-10-19 22:50:32 UTC) #3
keertip
https://codereview.chromium.org/1419503002/diff/20001/pkg/analysis_server/benchmark/perf/analysis_timing_tests.dart File pkg/analysis_server/benchmark/perf/analysis_timing_tests.dart (right): https://codereview.chromium.org/1419503002/diff/20001/pkg/analysis_server/benchmark/perf/analysis_timing_tests.dart#newcode78 pkg/analysis_server/benchmark/perf/analysis_timing_tests.dart:78: stopwatch.reset(); On 2015/10/19 22:50:32, Brian Wilkerson wrote: > Does ...
5 years, 2 months ago (2015-10-19 23:10:11 UTC) #4
keertip
5 years, 2 months ago (2015-10-19 23:35:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
2a88bdac4adcc50a40d8f0724827b4bbfe949695 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698