Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: pkg/analysis_server/benchmark/perf/performance_tests.dart

Issue 1419503002: refactor timing tests to not use the test framework (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: remove unused code Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/benchmark/perf/completion_timing_tests.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/benchmark/perf/performance_tests.dart
diff --git a/pkg/analysis_server/benchmark/perf/performance_tests.dart b/pkg/analysis_server/benchmark/perf/performance_tests.dart
index 761c647972b98969faf9fc7da5db1406e0a8f341..62a752cd46e400f70d91bdadaea89f52beb92a6a 100644
--- a/pkg/analysis_server/benchmark/perf/performance_tests.dart
+++ b/pkg/analysis_server/benchmark/perf/performance_tests.dart
@@ -5,6 +5,7 @@
library server.performance;
import 'dart:async';
+import 'dart:io';
import 'package:analysis_server/plugin/protocol/protocol.dart';
import 'package:unittest/unittest.dart';
@@ -67,6 +68,13 @@ abstract class AbstractAnalysisServerPerformanceTest
/**
* After every test, the server is stopped.
*/
- @override
- Future tearDown() => shutdownIfNeeded();
+ Future shutdown() async => await shutdownIfNeeded();
+}
+
+class AbstractTimingTest extends AbstractAnalysisServerPerformanceTest {
+ Future init(String source) async {
+ await super.setUp();
+ sourceDirectory = new Directory(source);
+ return subscribeToStatusNotifications();
+ }
}
« no previous file with comments | « pkg/analysis_server/benchmark/perf/completion_timing_tests.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698