Add in gesture for immersive mode

Add in gesture for immersive mode

Adds in a swipe in from the top of the screen to the BorderGestureHandler. This
gestures causes the tab strip to reveal in the same fashion that moving the
mouse to the top of the screen in immersive mode.

Currently the tab strip does not reveal by being sticky to the finger like the
shelf swipe in. Implementing stickiness will require a significant effort and it
is not clear if it is needed yet. There is also an issue with touches outside
the tab strip not hidding the shelf, which is left to be resolved in another CL.

BUG=chromium:164165
TEST=Entered immersive mode and swiped in from the top of the screen, which
     caused the tab strip to animate in.

[sadrul, 2013-04-19 01:41:20]

I looked at just BorderGestureHandler changes. I'll leave the immersive changes
for pkotwicz@/jamescook@

https://codereview.chromium.org/14195016/diff/1/ash/wm/gestures/border_gestur...
File ash/wm/gestures/border_gesture_handler.cc (right):

https://codereview.chromium.org/14195016/diff/1/ash/wm/gestures/border_gestur...
ash/wm/gestures/border_gesture_handler.cc:80:
target->GetRootWindow())->SetPendingImmersiveGesture(true);
I think you should do this in SCROLL_BEGIN

https://codereview.chromium.org/14195016/diff/1/ash/wm/gestures/border_gestur...
File ash/wm/gestures/border_gesture_handler.h (right):

https://codereview.chromium.org/14195016/diff/1/ash/wm/gestures/border_gestur...
ash/wm/gestures/border_gesture_handler.h:115: BorderGestureType gesture_type_;
It doesn't look like you are using gesture_type_? I like the idea of using
gesture_type_ instead of having IsGestureInImmersiveOrientation etc.

[pkotwicz, 2013-04-19 06:06:44]

I will do a more thorough review on Saturday

https://codereview.chromium.org/14195016/diff/1/ash/root_window_controller.cc
File ash/root_window_controller.cc (right):

https://codereview.chromium.org/14195016/diff/1/ash/root_window_controller.cc...
ash/root_window_controller.cc:526: }
Can you modify RootWindowController::IsImmersiveMode() to be
RootWindowController::GetFullscreenWindow() instead?
This would allow you to move the rest of this function's logic to
border_gesture_handler.

[pkotwicz, 2013-04-21 21:18:19]

I don't really like how we get the event to ImmersiveModeControllerAsh but I
can't think of a better way.
I am adding jamescook@ in case he has any ideas.

Otherwise, the CL looks good.

https://codereview.chromium.org/14195016/diff/1/ash/root_window_controller.cc
File ash/root_window_controller.cc (right):

https://codereview.chromium.org/14195016/diff/1/ash/root_window_controller.cc...
ash/root_window_controller.cc:526: }
FYI: I have implemented GetFullscreenWindow() as part of
https://codereview.chromium.org/14156005/ so you can probably steal the
implementation from there.

[James Cook, 2013-04-22 18:19:28]

https://codereview.chromium.org/14195016/diff/1/ash/root_window_controller.h
File ash/root_window_controller.h (right):

https://codereview.chromium.org/14195016/diff/1/ash/root_window_controller.h#...
ash/root_window_controller.h:179: void SetPendingImmersiveGesture(bool value);
This doesn't feel like it belongs in the RootWindowController. In fact, Peter
just removed the IsImmersiveMode() function above and I think we can remove the
kImmersiveMode window property key.  Can this be wired to call up through the
ChromeShellDelegate and query immersive mode from there?

[rharrison, 2013-04-22 18:36:52]

Responded to comments. I will have a new CL up later today or more likely
tomorrow.

https://codereview.chromium.org/14195016/diff/1/ash/root_window_controller.cc
File ash/root_window_controller.cc (right):

https://codereview.chromium.org/14195016/diff/1/ash/root_window_controller.cc...
ash/root_window_controller.cc:526: }
On 2013/04/21 21:18:19, pkotwicz wrote:
> FYI: I have implemented GetFullscreenWindow() as part of
> https://codereview.chromium.org/14156005/ so you can probably steal the
> implementation from there.

I will change the related code to use GetFullscreenWindow()

https://codereview.chromium.org/14195016/diff/1/ash/root_window_controller.h
File ash/root_window_controller.h (right):

https://codereview.chromium.org/14195016/diff/1/ash/root_window_controller.h#...
ash/root_window_controller.h:179: void SetPendingImmersiveGesture(bool value);
On 2013/04/22 18:19:28, James Cook (Chromium) wrote:
> This doesn't feel like it belongs in the RootWindowController. In fact, Peter
> just removed the IsImmersiveMode() function above and I think we can remove
the
> kImmersiveMode window property key.  Can this be wired to call up through the
> ChromeShellDelegate and query immersive mode from there?

I suspect so, I will have to look into it.

https://codereview.chromium.org/14195016/diff/1/ash/wm/gestures/border_gestur...
File ash/wm/gestures/border_gesture_handler.cc (right):

https://codereview.chromium.org/14195016/diff/1/ash/wm/gestures/border_gestur...
ash/wm/gestures/border_gesture_handler.cc:80:
target->GetRootWindow())->SetPendingImmersiveGesture(true);
On 2013/04/19 01:41:20, sadrul wrote:
> I think you should do this in SCROLL_BEGIN
I agree, I suspect this is a typo

https://codereview.chromium.org/14195016/diff/1/ash/wm/gestures/border_gestur...
File ash/wm/gestures/border_gesture_handler.h (right):

https://codereview.chromium.org/14195016/diff/1/ash/wm/gestures/border_gestur...
ash/wm/gestures/border_gesture_handler.h:115: BorderGestureType gesture_type_;
On 2013/04/19 01:41:20, sadrul wrote:
> It doesn't look like you are using gesture_type_? I like the idea of using
> gesture_type_ instead of having IsGestureInImmersiveOrientation etc.

This I think was left over cruft from something I was trying. I will have to
think over your idea a bit.

[rharrison, 2013-04-24 14:07:41]

Rewriting how edge gestures work for the shelf, which should simplify things.
Will update this  CL once that is done.
On 2013/04/22 18:36:52, rharrison wrote:
> Responded to comments. I will have a new CL up later today or more likely
> tomorrow.
> 
> https://codereview.chromium.org/14195016/diff/1/ash/root_window_controller.cc
> File ash/root_window_controller.cc (right):
> 
>
https://codereview.chromium.org/14195016/diff/1/ash/root_window_controller.cc...
> ash/root_window_controller.cc:526: }
> On 2013/04/21 21:18:19, pkotwicz wrote:
> > FYI: I have implemented GetFullscreenWindow() as part of
> > https://codereview.chromium.org/14156005/ so you can probably steal the
> > implementation from there.
> 
> I will change the related code to use GetFullscreenWindow()
> 
> https://codereview.chromium.org/14195016/diff/1/ash/root_window_controller.h
> File ash/root_window_controller.h (right):
> 
>
https://codereview.chromium.org/14195016/diff/1/ash/root_window_controller.h#...
> ash/root_window_controller.h:179: void SetPendingImmersiveGesture(bool value);
> On 2013/04/22 18:19:28, James Cook (Chromium) wrote:
> > This doesn't feel like it belongs in the RootWindowController. In fact,
Peter
> > just removed the IsImmersiveMode() function above and I think we can remove
> the
> > kImmersiveMode window property key.  Can this be wired to call up through
the
> > ChromeShellDelegate and query immersive mode from there?
> 
> I suspect so, I will have to look into it.
> 
>
https://codereview.chromium.org/14195016/diff/1/ash/wm/gestures/border_gestur...
> File ash/wm/gestures/border_gesture_handler.cc (right):
> 
>
https://codereview.chromium.org/14195016/diff/1/ash/wm/gestures/border_gestur...
> ash/wm/gestures/border_gesture_handler.cc:80:
> target->GetRootWindow())->SetPendingImmersiveGesture(true);
> On 2013/04/19 01:41:20, sadrul wrote:
> > I think you should do this in SCROLL_BEGIN
> I agree, I suspect this is a typo
> 
>
https://codereview.chromium.org/14195016/diff/1/ash/wm/gestures/border_gestur...
> File ash/wm/gestures/border_gesture_handler.h (right):
> 
>
https://codereview.chromium.org/14195016/diff/1/ash/wm/gestures/border_gestur...
> ash/wm/gestures/border_gesture_handler.h:115: BorderGestureType gesture_type_;
> On 2013/04/19 01:41:20, sadrul wrote:
> > It doesn't look like you are using gesture_type_? I like the idea of using
> > gesture_type_ instead of having IsGestureInImmersiveOrientation etc.
> 
> This I think was left over cruft from something I was trying. I will have to
> think over your idea a bit.