Add in gesture for immersive mode

ash/wm/gestures/border_gesture_handler.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_WM_GESTURES_BORDER_GESTURE_HANDLER_H_
 #define ASH_WM_GESTURES_BORDER_GESTURE_HANDLER_H_
 
 
 
 #include <bitset>
@@ skipping 28 matching lines @@
 enum BorderLocation {
   BORDER_LOCATION_BOTTOM = 0,
   BORDER_LOCATION_LEFT = 1,
   BORDER_LOCATION_TOP = 2,
   BORDER_LOCATION_RIGHT = 3,
   NUM_BORDER_LOCATIONS
 };
 
 typedef std::bitset<NUM_BORDER_LOCATIONS> BorderFlags;
 
+enum BorderGestureType {
+  BORDER_GESTURE_TYPE_LAUNCHER,
+  BORDER_GESTURE_TYPE_IMMERSIVE,
+  BORDER_GESTURE_TYPE_UNKNOWN
+};
+
 // Handles touch gestures that occur around the border of the display area that
 // might have actions associated with them. It handles both gestures that
 // require a bezel sensor (bezel gestures) and those that do not (edge
 // gestures).
 class BorderGestureHandler {
  public:
   BorderGestureHandler();
   ~BorderGestureHandler();
 
   // Returns true of the gesture has been handled and it should not be processed
   // any farther, false otherwise.
   bool ProcessGestureEvent(aura::Window* target, const ui::GestureEvent& event);
 
  private:
-  // Handle events meant for showing the launcher. Returns true when no further
-  // events from this gesture should be sent.
+  // Handle events meant for showing tabstrip in immersive mode. Returns true
+  // when the event has been consumed, false otherwise.
+  bool HandleImmersiveControl(aura::Window* target,
+                              const ui::GestureEvent& event);
+
+  // Handle events meant for showing the launcher. Returns true
+  // when the event has been consumed, false otherwise.
   bool HandleLauncherControl(const ui::GestureEvent& event);
 
   bool HandleBorderGestureStart(aura::Window* target,
                                 const ui::GestureEvent& event);
 
   // Handles a gesture update once the orientation has been found.
   bool HandleBorderGestureUpdate(aura::Window* target,
                                  const ui::GestureEvent& event);
 
   bool HandleBorderGestureEnd(aura::Window* target,
                               const ui::GestureEvent& event);
 
   // Check that gesture starts on a bezel or in the edge region of the
   // screen. If so, set bits in |start_location_|.
   void GestureStartInTargetArea(const gfx::Rect& screen,
                                 const ui::GestureEvent& event);
 
   // Determine the gesture orientation (if not yet done).
   // Returns true when the orientation has been successfully determined.
   bool DetermineGestureOrientation(const ui::GestureEvent& event);
 
+  // Test if the gesture orientation makes sense to be trying to display the
+  // tabstrip in immersive mode.
+  bool IsGestureInImmersiveOrientation(const ui::GestureEvent& event);
+
   // Test if the gesture orientation makes sense to be dragging in or out the
   // launcher.
   bool IsGestureInLauncherOrientation(const ui::GestureEvent& event);
 
   // Which bezel/edges the gesture started in. In the case that a gesture begins
   // in a corner of the screen more then one flag may be set and the orientation
   // of the gesture will be needed to disambiguate.
   BorderFlags start_location_;
 
   // Orientation relative to the screen that the gesture is moving in
   BorderScrollOrientation orientation_;
 
+  // Allows tracking of current gesture type, so if a new one starts the handler
+  // can end the previous gesture
+  BorderGestureType gesture_type_;

[sadrul, 2013/04/19 01:41:20]

It doesn't look like you are using gesture_type_? I like the idea of using
gesture_type_ instead of having IsGestureInImmersiveOrientation etc.

[rharrison, 2013/04/22 18:36:52]

This I think was left over cruft from something I was trying. I will have to
think over your idea a bit.

+
   ShelfGestureHandler shelf_handler_;
 
   DISALLOW_COPY_AND_ASSIGN(BorderGestureHandler);
 };
 
 }  // namespace internal
 }  // namespace ash
 #endif  // ASH_WM_GESTURES_BORDER_GESTURE_HANDLER_H_