Issue 14195005: DevTools: Fix missing message about the snapshot is too big.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14195005: DevTools: Fix missing message about the snapshot is too big. (Closed)

Created:
7 years, 8 months ago by alph

Modified:
7 years, 8 months ago

Reviewers:
Toon Verwaest, yurys, loislo

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

DevTools: Fix missing message about the snapshot is too big. The message object has to have a shortcut link from the root. Otherwise it is filtered out as a system object and not visible to the user. R=yurys@chromium.org

Patch Set 1 #

Total comments: 2

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/heap-snapshot-generator.cc	View		1 chunk	+2 lines, -2 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

yurys

https://codereview.chromium.org/14195005/diff/1/src/heap-snapshot-generator.cc File src/heap-snapshot-generator.cc (left): https://codereview.chromium.org/14195005/diff/1/src/heap-snapshot-generator.cc#oldcode2420 src/heap-snapshot-generator.cc:2420: result->root()->SetIndexedReference(HeapGraphEdge::kElement, 1, message); Can you add a test for ...

7 years, 8 months ago (2013-04-18 07:05:40 UTC) #3

alph

7 years, 8 months ago (2013-04-18 09:09:08 UTC) #4

https://codereview.chromium.org/14195005/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (left):

https://codereview.chromium.org/14195005/diff/1/src/heap-snapshot-generator.c...
src/heap-snapshot-generator.cc:2420:
result->root()->SetIndexedReference(HeapGraphEdge::kElement, 1, message);
On 2013/04/18 07:05:41, Yury Semikhatsky wrote:
> Can you add a test for this?
To trigger this code execution I have to create a 6GB snapshot. I don't think
the test worths it.

Expand Messages | Collapse Messages