Fix task concurrency in components/update_client

Fix task concurrency in components/update_client

1. Only dequeue pending tasks when no other tasks are running.
2. Use the running tasks list to accept or reject a foreground task.

BUG=549305
Committed: https://crrev.com/08d153c2a2964510cff3d5e9f4f46d19b94e4f5c
Cr-Commit-Position: refs/heads/master@{#356992}

[Sorin Jianu, 2015-10-29 22:44:28]

sorin@chromium.org changed reviewers:
+ waffles@chromium.org

[waffles, 2015-10-29 22:59:33]

lgtm

https://codereview.chromium.org/1419473005/diff/20001/components/update_clien...
File components/update_client/update_client_internal.h (right):

https://codereview.chromium.org/1419473005/diff/20001/components/update_clien...
components/update_client/update_client_internal.h:68: // Contains the tasks that
are queued up. In the current implementation,
Maybe say "pending" instead of "queued up".

(It's obvious that a queue of task contains queued tasks.)

https://codereview.chromium.org/1419473005/diff/20001/components/update_clien...
components/update_client/update_client_internal.h:78: // is not allowed.
is -> are

[Sorin Jianu, 2015-10-29 23:04:30]

ty, all done.

[Sorin Jianu, 2015-10-29 23:05:52]

The CQ bit was checked by sorin@chromium.org

[Sorin Jianu, 2015-10-29 23:05:53]

The patchset sent to the CQ was uploaded after l-g-t-m from waffles@chromium.org
Link to the patchset: https://codereview.chromium.org/1419473005/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-10-29 23:07:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419473005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419473005/40001

[commit-bot: I haz the power, 2015-10-30 00:04:26]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-30 00:05:37]

Patchset 3 (id:??) landed as
https://crrev.com/08d153c2a2964510cff3d5e9f4f46d19b94e4f5c
Cr-Commit-Position: refs/heads/master@{#356992}

[Nico, 2015-11-04 23:31:24]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-11-04 23:31:25]

https://codereview.chromium.org/1419473005/diff/40001/components/update_clien...
File components/update_client/update_client.cc (right):

https://codereview.chromium.org/1419473005/diff/40001/components/update_clien...
components/update_client/update_client.cc:185: if (std::find(std::begin(ids),
std::end(ids), id) != std::end(ids)) {
chromium-cpp.appspot.com says "Unless otherwise noted, no C++11 library features
are allowed.". std::begin() is a c++11 library feature. Please say ids.begin()
instead for now. (This is a problem 'cause the OS X libc++ rollout isn't done
and I need to build with libstdc++ locally to debug things still.)

[Sorin Jianu, 2015-11-04 23:37:00]

Will do.

https://codereview.chromium.org/1419473005/diff/40001/components/update_clien...
File components/update_client/update_client.cc (right):

https://codereview.chromium.org/1419473005/diff/40001/components/update_clien...
components/update_client/update_client.cc:185: if (std::find(std::begin(ids),
std::end(ids), id) != std::end(ids)) {
On 2015/11/04 23:31:25, Nico wrote:
> http://chromium-cpp.appspot.com says "Unless otherwise noted, no C++11 library
features
> are allowed.". std::begin() is a c++11 library feature. Please say ids.begin()
> instead for now. (This is a problem 'cause the OS X libc++ rollout isn't done
> and I need to build with libstdc++ locally to debug things still.)

Acknowledged.

[Sorin Jianu, 2015-11-04 23:37:03]

Will do.