Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Unified Diff: components/update_client/update_engine.cc

Issue 1419473005: Fix task concurrency in components/update_client (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/update_client/update_engine.cc
diff --git a/components/update_client/update_engine.cc b/components/update_client/update_engine.cc
index 15ef333b28cbdc603fa75c45fa1e4e0355d6d024..e1ae81217903b5e391bdb72299cc0ab7c83540f4 100644
--- a/components/update_client/update_engine.cc
+++ b/components/update_client/update_engine.cc
@@ -60,20 +60,6 @@ UpdateEngine::~UpdateEngine() {
DCHECK(thread_checker_.CalledOnValidThread());
}
-bool UpdateEngine::IsUpdating(const std::string& id) const {
- DCHECK(thread_checker_.CalledOnValidThread());
- for (const auto& context : update_contexts_) {
- const auto& ids = context->ids;
- const auto it = std::find_if(
- ids.begin(), ids.end(),
- [id](const std::string& this_id) { return id == this_id; });
- if (it != ids.end()) {
- return true;
- }
- }
- return false;
-}
-
bool UpdateEngine::GetUpdateState(const std::string& id,
CrxUpdateItem* update_item) {
DCHECK(thread_checker_.CalledOnValidThread());
« components/update_client/update_client.cc ('K') | « components/update_client/update_engine.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698