Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1419403003: Fix DMSrcSink bug (Closed)

Created:
5 years, 1 month ago by msarett
Modified:
5 years, 1 month ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix DMSrcSink bug We want to request premultiplied decodes. BUG=skia: Committed: https://skia.googlesource.com/skia/+/90978148e71e525c887c389b2bec6c4cbbd1dee1

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M dm/DMSrcSink.cpp View 1 chunk +1 line, -1 line 1 comment Download

Depends on Patchset:

Issue 1188223002 Patch 60001

Messages

Total messages: 6 (2 generated)
msarett
5 years, 1 month ago (2015-10-27 13:53:26 UTC) #2
scroggo
lgtm https://codereview.chromium.org/1419403003/diff/1/dm/DMSrcSink.cpp File dm/DMSrcSink.cpp (right): https://codereview.chromium.org/1419403003/diff/1/dm/DMSrcSink.cpp#newcode267 dm/DMSrcSink.cpp:267: *decodeInfo = decodeInfo->makeAlphaType(kPremul_SkAlphaType); I wonder if makeAlphaType should ...
5 years, 1 month ago (2015-10-27 13:59:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419403003/1
5 years, 1 month ago (2015-10-27 14:01:23 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 14:12:27 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/90978148e71e525c887c389b2bec6c4cbbd1dee1

Powered by Google App Engine
This is Rietveld 408576698