Issue 14193: Fix lint errors - spacing and formatting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14193: Fix lint errors - spacing and formatting. (Closed)

Created:
12 years ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/toiger/

Visibility:
Public.

Description

Fix lint errors - spacing and formatting. Committed: http://code.google.com/p/v8/source/detail?r=992

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -8 lines)			Patch
M	src/codegen-ia32.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/codegen-ia32.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/jump-target-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/register-allocator-ia32.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/virtual-frame-arm.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

Here are a few lint fixes. I know you are removing the TODO anyway.

12 years ago (2008-12-17 13:38:51 UTC) #1

Kevin Millikin (Chromium)

12 years ago (2008-12-17 13:42:11 UTC) #2

LGTM.

http://codereview.chromium.org/14193/diff/1/5
File src/codegen-ia32.cc (right):

http://codereview.chromium.org/14193/diff/1/5#newcode4072
Line 4072: // that exits without a virtual frame in place?
This TODO can be removed, it is stale.

Expand Messages | Collapse Messages