Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: components/test_runner/test_common.cc

Issue 1419293005: Add assertions that the empty Platform::cryptographicallyRandomValues() overrides are not being use… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/blink/run_all_unittests.cc » ('j') | third_party/WebKit/Source/web/ImageDecodeBench.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/test_common.cc
diff --git a/components/test_runner/test_common.cc b/components/test_runner/test_common.cc
index ad06d5233e5a14889e49ea549d2c95eb1474d0ad..7f3081a0f2c05d66aa432ba339aa74c016c6a1cf 100644
--- a/components/test_runner/test_common.cc
+++ b/components/test_runner/test_common.cc
@@ -5,6 +5,7 @@
#include "components/test_runner/test_common.h"
#include "base/lazy_instance.h"
+#include "base/logging.h"
#include "base/macros.h"
#include "third_party/WebKit/public/platform/Platform.h"
#include "third_party/WebKit/public/web/WebKit.h"
@@ -30,7 +31,10 @@ class MockBlinkPlatform : NON_EXPORTED_BASE(public blink::Platform) {
}
~MockBlinkPlatform() override {}
void cryptographicallyRandomValues(unsigned char* buffer,
- size_t length) override {}
+ size_t length) override {
+ NOTREACHED();
jww 2015/11/10 18:43:16 Why isn't this an ASSERT_NOT_REACHED()? Wouldn't w
eroman 2015/11/10 19:26:14 (1) ASSERT_NOT_REACHED() is compiled out of Releas
jww 2015/11/10 19:32:26 Ah, got it! Good call all around. (1) Yes, I thin
eroman 2015/11/10 19:45:56 Done: * I changed to RELEASE_ASSERT_NOT_REACHED(
+ }
+
private:
DISALLOW_COPY_AND_ASSIGN(MockBlinkPlatform);
};
« no previous file with comments | « no previous file | media/blink/run_all_unittests.cc » ('j') | third_party/WebKit/Source/web/ImageDecodeBench.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698