Add assertions that the empty Platform::cryptographicallyRandomValues() overrides are not being use…

third_party/WebKit/Source/web/ImageDecodeBench.cpp

Index: third_party/WebKit/Source/web/ImageDecodeBench.cpp
diff --git a/third_party/WebKit/Source/web/ImageDecodeBench.cpp b/third_party/WebKit/Source/web/ImageDecodeBench.cpp
index 98f7fa12be195937213699d4b61f55a1bbf9ff9e..1e94248c524966edb228c2666128acea12738d75 100644
--- a/third_party/WebKit/Source/web/ImageDecodeBench.cpp
+++ b/third_party/WebKit/Source/web/ImageDecodeBench.cpp
@@ -369,7 +369,7 @@ int main(int argc, char* argv[])
 
         void cryptographicallyRandomValues(unsigned char*, size_t) override

[jww, 2015/11/10 18:43:16]

There was a comment in one of the other classes explaining that this needs to be
overridden to be useful/secure; maybe copy that comment here, too? Or at least
have a comment explaining the security concern.

[eroman, 2015/11/10 19:26:14]

The existing comment here was wrong here which is why I deleted it (there is no
"default" that gets used if this function does nothing).

I could add a comment explaining that this needs to be implemented if it is
used?

         {
-            // Do nothing: make blink::Platform use the default crypto-randoms.
+            ASSERT_NOT_REACHED();
         }
 
         void screenColorProfile(WebVector<char>* profile) override