Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1206)

Side by Side Diff: third_party/WebKit/Source/platform/fonts/FontCacheTest.cpp

Issue 1419293005: Add assertions that the empty Platform::cryptographicallyRandomValues() overrides are not being use… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change to RELEASE_ASSERT and use base::RandBytes() in Chromium. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "platform/fonts/FontCache.h" 6 #include "platform/fonts/FontCache.h"
7 7
8 #include "platform/fonts/FontDescription.h" 8 #include "platform/fonts/FontDescription.h"
9 #include "platform/fonts/SimpleFontData.h" 9 #include "platform/fonts/SimpleFontData.h"
10 #include "public/platform/Platform.h" 10 #include "public/platform/Platform.h"
11 #include <gtest/gtest.h> 11 #include <gtest/gtest.h>
12 12
13 namespace blink { 13 namespace blink {
14 14
15 class EmptyPlatform : public Platform { 15 class EmptyPlatform : public Platform {
16 public: 16 public:
17 EmptyPlatform() {} 17 EmptyPlatform() {}
18 ~EmptyPlatform() override {} 18 ~EmptyPlatform() override {}
19 void cryptographicallyRandomValues(unsigned char* buffer, size_t length) ove rride { } 19 void cryptographicallyRandomValues(unsigned char* buffer, size_t length) ove rride
20 {
21 RELEASE_ASSERT_NOT_REACHED();
22 }
20 }; 23 };
21 24
22 TEST(FontCache, getLastResortFallbackFont) 25 TEST(FontCache, getLastResortFallbackFont)
23 { 26 {
24 FontCache* fontCache = FontCache::fontCache(); 27 FontCache* fontCache = FontCache::fontCache();
25 ASSERT_TRUE(fontCache); 28 ASSERT_TRUE(fontCache);
26 29
27 Platform* oldPlatform = Platform::current(); 30 Platform* oldPlatform = Platform::current();
28 OwnPtr<EmptyPlatform> platform = adoptPtr(new EmptyPlatform); 31 OwnPtr<EmptyPlatform> platform = adoptPtr(new EmptyPlatform);
29 Platform::initialize(platform.get()); 32 Platform::initialize(platform.get());
30 33
31 FontDescription fontDescription; 34 FontDescription fontDescription;
32 fontDescription.setGenericFamily(FontDescription::StandardFamily); 35 fontDescription.setGenericFamily(FontDescription::StandardFamily);
33 RefPtr<SimpleFontData> fontData = fontCache->getLastResortFallbackFont(fontD escription, Retain); 36 RefPtr<SimpleFontData> fontData = fontCache->getLastResortFallbackFont(fontD escription, Retain);
34 EXPECT_TRUE(fontData); 37 EXPECT_TRUE(fontData);
35 38
36 fontDescription.setGenericFamily(FontDescription::SansSerifFamily); 39 fontDescription.setGenericFamily(FontDescription::SansSerifFamily);
37 fontData = fontCache->getLastResortFallbackFont(fontDescription, Retain); 40 fontData = fontCache->getLastResortFallbackFont(fontDescription, Retain);
38 EXPECT_TRUE(fontData); 41 EXPECT_TRUE(fontData);
39 42
40 Platform::initialize(oldPlatform); 43 Platform::initialize(oldPlatform);
41 } 44 }
42 45
43 } // namespace blink 46 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698