Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: third_party/WebKit/Source/platform/TestingPlatformSupport.cpp

Issue 1419293005: Add assertions that the empty Platform::cryptographicallyRandomValues() overrides are not being use… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change to RELEASE_ASSERT and use base::RandBytes() in Chromium. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 Platform::initialize(m_oldPlatform); 81 Platform::initialize(m_oldPlatform);
82 } 82 }
83 83
84 WebDiscardableMemory* TestingPlatformSupport::allocateAndLockDiscardableMemory(s ize_t bytes) 84 WebDiscardableMemory* TestingPlatformSupport::allocateAndLockDiscardableMemory(s ize_t bytes)
85 { 85 {
86 return !m_config.hasDiscardableMemorySupport ? 0 : new TestingDiscardableMem ory(bytes); 86 return !m_config.hasDiscardableMemorySupport ? 0 : new TestingDiscardableMem ory(bytes);
87 } 87 }
88 88
89 void TestingPlatformSupport::cryptographicallyRandomValues(unsigned char* buffer , size_t length) 89 void TestingPlatformSupport::cryptographicallyRandomValues(unsigned char* buffer , size_t length)
90 { 90 {
91 RELEASE_ASSERT_NOT_REACHED();
91 } 92 }
92 93
93 const unsigned char* TestingPlatformSupport::getTraceCategoryEnabledFlag(const c har* categoryName) 94 const unsigned char* TestingPlatformSupport::getTraceCategoryEnabledFlag(const c har* categoryName)
94 { 95 {
95 static const unsigned char tracingIsDisabled = 0; 96 static const unsigned char tracingIsDisabled = 0;
96 return &tracingIsDisabled; 97 return &tracingIsDisabled;
97 } 98 }
98 99
99 WebString TestingPlatformSupport::defaultLocale() 100 WebString TestingPlatformSupport::defaultLocale()
100 { 101 {
101 return WebString::fromUTF8("en-US"); 102 return WebString::fromUTF8("en-US");
102 } 103 }
103 104
104 } // namespace blink 105 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698