Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1419273008: [Interpreter] Add support for new.target (Closed)

Created:
5 years, 1 month ago by rmcilroy
Modified:
5 years, 1 month ago
Reviewers:
oth
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@int_thisfunc
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add support for new.target BUG=v8:4280 LOG=N Committed: https://crrev.com/e5e1454bad1360eb133f88ad50cf4b34e2c60cf3 Cr-Commit-Position: refs/heads/master@{#31862}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -3 lines) Patch
M src/interpreter/bytecode-generator.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 chunk +18 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (4 generated)
rmcilroy
This is needed due to use of new.target within the v8natives.js. PTAL, thanks.
5 years, 1 month ago (2015-11-04 18:17:25 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419273008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419273008/1
5 years, 1 month ago (2015-11-04 18:34:17 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-04 19:00:11 UTC) #6
oth
lgtm. Before this CL I didn't know this feature existed :-)
5 years, 1 month ago (2015-11-06 14:40:43 UTC) #7
rmcilroy
On 2015/11/06 14:40:43, oth wrote: > lgtm. Before this CL I didn't know this feature ...
5 years, 1 month ago (2015-11-06 14:50:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419273008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419273008/1
5 years, 1 month ago (2015-11-06 15:04:14 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-06 15:45:59 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 15:46:19 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5e1454bad1360eb133f88ad50cf4b34e2c60cf3
Cr-Commit-Position: refs/heads/master@{#31862}

Powered by Google App Engine
This is Rietveld 408576698