Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1020)

Issue 1406253008: [Interpreter] Add support for VisitThisFunction. (Closed)

Created:
5 years, 1 month ago by rmcilroy
Modified:
5 years, 1 month ago
Reviewers:
oth
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@int_jsruntime
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add support for VisitThisFunction. BUG=v8:4280 LOG=N Committed: https://crrev.com/8c32ef6ee87f5853e7c50a268ac7e7b4a9b4e5db Cr-Commit-Position: refs/heads/master@{#31859}

Patch Set 1 #

Patch Set 2 : Add tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -1 line) Patch
M src/interpreter/bytecode-generator.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 1 chunk +41 lines, -0 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (4 generated)
rmcilroy
I'm not sure how to test this, but it is a pretty simple visitor. PTAL, ...
5 years, 1 month ago (2015-10-30 17:59:31 UTC) #2
oth
On 2015/10/30 17:59:31, rmcilroy wrote: > I'm not sure how to test this, but it ...
5 years, 1 month ago (2015-11-02 09:56:03 UTC) #3
rmcilroy
On 2015/11/02 09:56:03, oth wrote: > On 2015/10/30 17:59:31, rmcilroy wrote: > > I'm not ...
5 years, 1 month ago (2015-11-04 17:48:28 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406253008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406253008/20001
5 years, 1 month ago (2015-11-04 17:52:27 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-04 18:14:43 UTC) #8
oth
lgtm
5 years, 1 month ago (2015-11-06 14:38:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406253008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406253008/20001
5 years, 1 month ago (2015-11-06 14:42:28 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-06 15:00:30 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 15:01:13 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8c32ef6ee87f5853e7c50a268ac7e7b4a9b4e5db
Cr-Commit-Position: refs/heads/master@{#31859}

Powered by Google App Engine
This is Rietveld 408576698