Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1077)

Unified Diff: runtime/vm/assembler_arm_test.cc

Issue 1419223003: Re-assign registers on ARM so PP and CODE_REG are below R7 (FP on iOS). (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_arm.cc ('k') | runtime/vm/code_patcher_arm_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_arm_test.cc
diff --git a/runtime/vm/assembler_arm_test.cc b/runtime/vm/assembler_arm_test.cc
index 6eafd9c460c0e9ca91d282bb08fee428cb8b20fb..12f470af2e02e475af23207be2bb5df828a2817f 100644
--- a/runtime/vm/assembler_arm_test.cc
+++ b/runtime/vm/assembler_arm_test.cc
@@ -1174,33 +1174,33 @@ ASSEMBLER_TEST_GENERATE(Ldm_stm_da, assembler) {
__ mov(R1, Operand(7));
__ mov(R2, Operand(11));
__ mov(R3, Operand(31));
- __ Push(R5); // We use R5 as accumulator.
- __ Push(R5);
- __ Push(R5);
- __ Push(R5);
- __ Push(R5);
+ __ Push(R9); // We use R9 as accumulator.
+ __ Push(R9);
+ __ Push(R9);
+ __ Push(R9);
+ __ Push(R9);
__ Push(R0); // Make room, so we can decrement after.
__ stm(DA_W, SP, (1 << R0 | 1 << R1 | 1 << R2 | 1 << R3));
__ str(R2, Address(SP)); // Should be a free slot.
- __ ldr(R5, Address(SP, 1 * kWordSize)); // R0. R5 = +1.
+ __ ldr(R9, Address(SP, 1 * kWordSize)); // R0. R9 = +1.
__ ldr(IP, Address(SP, 2 * kWordSize)); // R1.
- __ sub(R5, R5, Operand(IP)); // -R1. R5 = -6.
+ __ sub(R9, R9, Operand(IP)); // -R1. R9 = -6.
__ ldr(IP, Address(SP, 3 * kWordSize)); // R2.
- __ add(R5, R5, Operand(IP)); // +R2. R5 = +5.
+ __ add(R9, R9, Operand(IP)); // +R2. R9 = +5.
__ ldr(IP, Address(SP, 4 * kWordSize)); // R3.
- __ sub(R5, R5, Operand(IP)); // -R3. R5 = -26.
+ __ sub(R9, R9, Operand(IP)); // -R3. R9 = -26.
__ ldm(IB_W, SP, (1 << R0 | 1 << R1 | 1 << R2 | 1 << R3));
// Same operations again. But this time from the restore registers.
- __ add(R5, R5, Operand(R0));
- __ sub(R5, R5, Operand(R1));
- __ add(R5, R5, Operand(R2));
- __ sub(R0, R5, Operand(R3)); // R0 = result = -52.
+ __ add(R9, R9, Operand(R0));
+ __ sub(R9, R9, Operand(R1));
+ __ add(R9, R9, Operand(R2));
+ __ sub(R0, R9, Operand(R3)); // R0 = result = -52.
__ Pop(R1); // Remove storage slot.
- __ Pop(R5); // Restore R5.
- __ Pop(R5); // Restore R5.
- __ Pop(R5); // Restore R5.
- __ Pop(R5); // Restore R5.
- __ Pop(R5); // Restore R5.
+ __ Pop(R9); // Restore R9.
+ __ Pop(R9); // Restore R9.
+ __ Pop(R9); // Restore R9.
+ __ Pop(R9); // Restore R9.
+ __ Pop(R9); // Restore R9.
__ bx(LR);
}
« no previous file with comments | « runtime/vm/assembler_arm.cc ('k') | runtime/vm/code_patcher_arm_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698