runtime/vm/assembler_arm.cc - Issue 1419223003: Re-assign registers on ARM so PP and CODE_REG are below R7 (FP on iOS).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/assembler_arm.cc

Issue 1419223003: Re-assign registers on ARM so PP and CODE_REG are below R7 (FP on iOS). (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/assembler_arm.cc

diff --git a/runtime/vm/assembler_arm.cc b/runtime/vm/assembler_arm.cc

index f7ae21e709ffb637d61e10dbdc38225a406ecb8e..f49cfe6f25e0bae7e5dab4f5ffa66c9dd11b8b44 100644

--- a/runtime/vm/assembler_arm.cc

+++ b/runtime/vm/assembler_arm.cc

@@ -3308,7 +3308,7 @@ void Assembler::CallRuntime(const RuntimeEntry& entry,

void Assembler::EnterDartFrame(intptr_t frame_size) {

ASSERT(!constant_pool_allowed());

- // Registers are pushed in descending order: R9 | R10 | R11 | R14.

+ // Registers are pushed in descending order: R5 | R6 | R11 | R14.

EnterFrame((1 << PP) | (1 << CODE_REG) | (1 << FP) | (1 << LR), 0);

// Setup pool pointer for this dart function.

« no previous file with comments | « no previous file | runtime/vm/assembler_arm_test.cc » ('j') | no next file with comments »