Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1419093004: [DevTools] Fix crash in Page.reload when there is no visible entry. (Closed)

Created:
5 years, 1 month ago by dgozman
Modified:
5 years, 1 month ago
Reviewers:
pfeldman
CC:
chromium-reviews, darin-cc_chromium.org, jam, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix crash in Page.reload when there is no visible entry. BUG=550789 Committed: https://crrev.com/ff2c226ca3987bd30241845a4292da693214290d Cr-Commit-Position: refs/heads/master@{#358387}

Patch Set 1 #

Patch Set 2 : nullptr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M content/browser/devtools/protocol/devtools_protocol_browsertest.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M content/browser/devtools/protocol/page_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dgozman
Take a look please. This will be merged into M47.
5 years, 1 month ago (2015-11-05 22:48:40 UTC) #2
pfeldman
lgtm
5 years, 1 month ago (2015-11-05 23:12:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419093004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419093004/20001
5 years, 1 month ago (2015-11-06 18:16:51 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-06 21:00:20 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 21:01:14 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ff2c226ca3987bd30241845a4292da693214290d
Cr-Commit-Position: refs/heads/master@{#358387}

Powered by Google App Engine
This is Rietveld 408576698