Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(901)

Unified Diff: content/browser/devtools/protocol/devtools_protocol_browsertest.cc

Issue 1419093004: [DevTools] Fix crash in Page.reload when there is no visible entry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nullptr Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/devtools/protocol/page_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/protocol/devtools_protocol_browsertest.cc
diff --git a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
index 2a7bf358e6db46c74e0df393f982cfaee1ef25a0..f8cae1af3cc380b587ad2d81ff5008e9cc12a4a7 100644
--- a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
+++ b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
@@ -470,4 +470,16 @@ IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, InspectDuringFrameSwap) {
EXPECT_TRUE(success);
}
+IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, ReloadBlankPage) {
+ Shell* window = Shell::CreateNewWindow(
+ shell()->web_contents()->GetBrowserContext(),
+ GURL("javascript:x=1"),
+ nullptr,
+ gfx::Size());
+ WaitForLoadStop(window->web_contents());
+ Attach();
+ SendCommand("Page.reload", nullptr, false);
+ // Should not crash at this point.
+}
+
} // namespace content
« no previous file with comments | « no previous file | content/browser/devtools/protocol/page_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698