Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1419073003:
Send SkDebugf through stderr and flush on Windows too. (Closed)
DescriptionSend SkDebugf through stderr and flush on Windows too.
This makes it consistent with Linux/Mac. There, stderr is not buffered, so the flush is not needed / implicit.
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/bdef140b5092b129936937cdcba8ffc2a9a5332b
Patch Set 1 #Patch Set 2 : and flush #Messages
Total messages: 16 (6 generated)
Description was changed from ========== Send SkDebugf through stderr on Windows too. BUG=skia: ========== to ========== Send SkDebugf through stderr and flush on Windows too. This makes it consistent with Linux/Mac. BUG=skia: ==========
Description was changed from ========== Send SkDebugf through stderr and flush on Windows too. This makes it consistent with Linux/Mac. BUG=skia: ========== to ========== Send SkDebugf through stderr and flush on Windows too. This makes it consistent with Linux/Mac. There, stderr is not buffered, so the flush is not needed / implicit. BUG=skia: ==========
The CQ bit was checked by mtklein@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419073003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419073003/20001
The CQ bit was unchecked by mtklein@google.com
mtklein@chromium.org changed reviewers: + bsalomon@google.com - mtklein@google.com
I have little opinion on whether SkDebugf should go via stdout or stderr, but it'd be nice if it were the same and uniformly unbuffered on all platforms.
On 2015/10/28 16:36:40, mtklein_C wrote: > I have little opinion on whether SkDebugf should go via stdout or stderr, but > it'd be nice if it were the same and uniformly unbuffered on all platforms. lgtm, but should we just remove fflush?
On 2015/10/28 at 16:43:32, bsalomon wrote: > On 2015/10/28 16:36:40, mtklein_C wrote: > > I have little opinion on whether SkDebugf should go via stdout or stderr, but > > it'd be nice if it were the same and uniformly unbuffered on all platforms. > > lgtm, but should we just remove fflush? The flush makes nanobench/dm go from awkwardly stuttery to smooth output. I like it.
On 2015/10/28 16:44:32, mtklein wrote: > On 2015/10/28 at 16:43:32, bsalomon wrote: > > On 2015/10/28 16:36:40, mtklein_C wrote: > > > I have little opinion on whether SkDebugf should go via stdout or stderr, > but > > > it'd be nice if it were the same and uniformly unbuffered on all platforms. > > > > lgtm, but should we just remove fflush? > > The flush makes nanobench/dm go from awkwardly stuttery to smooth output. I > like it. Perhaps a comment as to why its there, so some future nit-picker doesn't remove it blindly, since it may be seen as not necessary.
On 2015/10/28 16:44:32, mtklein wrote: > On 2015/10/28 at 16:43:32, bsalomon wrote: > > On 2015/10/28 16:36:40, mtklein_C wrote: > > > I have little opinion on whether SkDebugf should go via stdout or stderr, > but > > > it'd be nice if it were the same and uniformly unbuffered on all platforms. > > > > lgtm, but should we just remove fflush? > > The flush makes nanobench/dm go from awkwardly stuttery to smooth output. I > like it. Ok sgtm. I don't why it was commented out in the first place.
On 2015/10/28 16:47:57, bsalomon wrote: > On 2015/10/28 16:44:32, mtklein wrote: > > On 2015/10/28 at 16:43:32, bsalomon wrote: > > > On 2015/10/28 16:36:40, mtklein_C wrote: > > > > I have little opinion on whether SkDebugf should go via stdout or stderr, > > but > > > > it'd be nice if it were the same and uniformly unbuffered on all > platforms. > > > > > > lgtm, but should we just remove fflush? > > > > The flush makes nanobench/dm go from awkwardly stuttery to smooth output. I > > like it. > > Ok sgtm. I don't why it was commented out in the first place. don't know why
On 2015/10/28 at 16:48:16, bsalomon wrote: > On 2015/10/28 16:47:57, bsalomon wrote: > > On 2015/10/28 16:44:32, mtklein wrote: > > > On 2015/10/28 at 16:43:32, bsalomon wrote: > > > > On 2015/10/28 16:36:40, mtklein_C wrote: > > > > > I have little opinion on whether SkDebugf should go via stdout or stderr, > > > but > > > > > it'd be nice if it were the same and uniformly unbuffered on all > > platforms. > > > > > > > > lgtm, but should we just remove fflush? > > > > > > The flush makes nanobench/dm go from awkwardly stuttery to smooth output. I > > > like it. > > > > Ok sgtm. I don't why it was commented out in the first place. > > don't know why Ditto.
The CQ bit was checked by mtklein@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419073003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419073003/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/bdef140b5092b129936937cdcba8ffc2a9a5332b |
