Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Unified Diff: src/ports/SkDebug_win.cpp

Issue 1419073003: Send SkDebugf through stderr and flush on Windows too. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: and flush Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ports/SkDebug_win.cpp
diff --git a/src/ports/SkDebug_win.cpp b/src/ports/SkDebug_win.cpp
index 8bbbef58e09d39cc60ca02df5f819426d1c5a604..ed706c1d7b83cc83708cdaa386534f12c4222fa8 100644
--- a/src/ports/SkDebug_win.cpp
+++ b/src/ports/SkDebug_win.cpp
@@ -21,11 +21,9 @@ void SkDebugf(const char format[], ...) {
va_list args;
va_start(args, format);
- vprintf(format, args);
+ vfprintf(stderr, format, args);
va_end(args);
- // When we crash on Windows we often are missing a lot of prints. Since we don't really care
- // about SkDebugf performance we flush after every print.
-// fflush(stdout);
+ fflush(stderr);
va_start(args, format);
vsnprintf(buffer, kBufferSize, format, args);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698