Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issue 1419053004: Revert of Fold out-of-flow objects into anonymous blocks when removing children (Closed)

Created:
5 years, 1 month ago by inferno
Modified:
5 years, 1 month ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@523282-3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fold out-of-flow objects into anonymous blocks when removing children (patchset #7 id:110001 of https://codereview.chromium.org/1406163003/ ) Reason for revert: Causing use-after-free crashes in entire rendering pipeline, reverting. Original issue's description: > Fold out-of-flow objects into anonymous blocks when removing children > > Sometimes when we remove a child we end up with a float or out-of-flow object beside > an anonymous block. When that happens, fold the float/out-of-flow object into the > anonymous box as that is where it would have lived if they were siblings in the > first place. > > BUG=322039 > > Committed: https://crrev.com/44402d152cd0bb788db3136ab08c3c76ec348cd1 > Cr-Commit-Position: refs/heads/master@{#357886} TBR=mstensho@opera.com,robhogan@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=322039

Patch Set 1 #

Messages

Total messages: 6 (2 generated)
inferno
Created Revert of Fold out-of-flow objects into anonymous blocks when removing children
5 years, 1 month ago (2015-11-05 16:05:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419053004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419053004/1
5 years, 1 month ago (2015-11-05 16:05:10 UTC) #2
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations: While running git apply --index -3 -p1; error: patch ...
5 years, 1 month ago (2015-11-05 16:05:57 UTC) #4
mstensho (USE GERRIT)
5 years, 1 month ago (2015-11-06 08:33:58 UTC) #6
New revert attempt in https://codereview.chromium.org/1411543009

Closing this.

Powered by Google App Engine
This is Rietveld 408576698