Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1411543009: Manually revert "Fold out-of-flow objects into anonymous blocks when removing children" (Closed)

Created:
5 years, 1 month ago by mstensho (USE GERRIT)
Modified:
5 years, 1 month ago
Reviewers:
rhogan
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Manually revert "Fold out-of-flow objects into anonymous blocks when removing children" Also revert "Auto-rebaseline for r357886" First attempt at reverting failed: https://codereview.chromium.org/1419053004/ Reason for revert: Causing use-after-free crashes in entire rendering pipeline, reverting. Original issue's description: > Fold out-of-flow objects into anonymous blocks when removing children > > Sometimes when we remove a child we end up with a float or out-of-flow object beside > an anonymous block. When that happens, fold the float/out-of-flow object into the > anonymous box as that is where it would have lived if they were siblings in the > first place. > > BUG=322039 > > Committed: https://crrev.com/44402d152cd0bb788db3136ab08c3c76ec348cd1 > Cr-Commit-Position: refs/heads/master@{#357886} TBR=robhogan@gmail.com BUG=322039 Committed: https://crrev.com/053b27991fc41af984d18d83f20dcba4e2cecb59 Cr-Commit-Position: refs/heads/master@{#358293}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -176 lines) Patch
D third_party/WebKit/LayoutTests/fast/block/float/add-inline-before-float-and-into-anonymous-block-container.html View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/block/float/add-inline-before-float-and-into-anonymous-block-container-expected.html View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/block/float/remove-div-after-float-and-before-anonymous-block-container.html View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/fast/block/float/remove-div-after-float-and-before-anonymous-block-container-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/fast/block/float/remove-div-after-float-and-before-anonymous-block-container-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/block/float/remove-div-after-float-and-before-anonymous-block-container-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/block/float/remove-div-after-float-and-before-anonymous-block-container-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/fast/block/float/remove-div-after-float-and-before-anonymous-block-container-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/fast/block/float/remove-div-after-float-and-before-anonymous-block-container-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/block/float/remove-div-after-float-and-before-anonymous-block-container-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/block/float/remove-div-after-float-and-before-anonymous-block-container-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 3 chunks +12 lines, -29 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
mstensho (USE GERRIT)
5 years, 1 month ago (2015-11-06 08:33:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411543009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411543009/1
5 years, 1 month ago (2015-11-06 08:34:28 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-06 09:53:16 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/053b27991fc41af984d18d83f20dcba4e2cecb59 Cr-Commit-Position: refs/heads/master@{#358293}
5 years, 1 month ago (2015-11-06 09:54:20 UTC) #5
mstensho (USE GERRIT)
5 years, 1 month ago (2015-11-06 09:58:35 UTC) #6
Message was sent while issue was closed.
Better mention bug 551916 here, which is about the regression.

Should have been in the BUG line in the description, but I just copied the text
from the other CL, and failed to notice that it was missing.

Powered by Google App Engine
This is Rietveld 408576698