[Cronet] Remove CriteriaHelper

[Cronet] Remove CriteriaHelper

CriteriaHelper seems to be a carry-over from ContentShell testing
code and isn't necessary for Cronet Sample instrumentation tests.

R=xunjieli
TEST=Instrumentation test CronetSampleTest

Committed: https://crrev.com/3c55da5faa5874d54f0ffa5e63b0dc6269a58990
Cr-Commit-Position: refs/heads/master@{#357107}

[pauljensen, 2015-10-29 13:44:56]

Helen, PTAL.

$ ./build/android/test_runner.py instrumentation --test-apk
out/Debug/apks/CronetSampleTest.apk --apk-under-test
out/Debug/apks/CronetSample.apk                               
W    0.377s Main  Creating 1 test runner.
W    0.378s 388e  Creating shard 0 for device 0667dbc20b35388e.
W    3.215s Main  Running tests with 1 test runner.
C    6.155s Main 
********************************************************************************
C    6.156s Main  Summary
C    6.156s Main 
********************************************************************************
C    6.156s Main  [==========] 1 test ran.
C    6.156s Main  [  PASSED  ] 1 test.
C    6.157s Main 
********************************************************************************

[xunjieli, 2015-10-29 18:06:46]

https://codereview.chromium.org/1419033005/diff/1/components/cronet/android/s...
File
components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleTest.java
(left):

https://codereview.chromium.org/1419033005/diff/1/components/cronet/android/s...
components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleTest.java:105:
isLoaded.set(!activity.isLoading() && !TextUtils
Do we need to take care of CronetSampleActivity.mLoading ? Now I looked at the
code, it is probably a bug that mLoading is never set to true.

[pauljensen, 2015-10-29 22:08:34]

https://codereview.chromium.org/1419033005/diff/1/components/cronet/android/s...
File
components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleTest.java
(left):

https://codereview.chromium.org/1419033005/diff/1/components/cronet/android/s...
components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleTest.java:105:
isLoaded.set(!activity.isLoading() && !TextUtils
On 2015/10/29 18:06:46, xunjieli wrote:
> Do we need to take care of CronetSampleActivity.mLoading ? Now I looked at the
> code, it is probably a bug that mLoading is never set to true.

Done, removed mLoading.

[xunjieli, 2015-10-29 22:13:57]

https://codereview.chromium.org/1419033005/diff/20001/components/cronet/andro...
File
components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleTest.java
(right):

https://codereview.chromium.org/1419033005/diff/20001/components/cronet/andro...
components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleTest.java:36:
assertEquals(URL, activity.getUrl());
Will there be a race case where the request might not have completed when we do
the asserts here?

[pauljensen, 2015-10-30 14:08:46]

On 2015/10/29 22:13:57, xunjieli wrote:
>
https://codereview.chromium.org/1419033005/diff/20001/components/cronet/andro...
> File
>
components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleTest.java
> (right):
> 
>
https://codereview.chromium.org/1419033005/diff/20001/components/cronet/andro...
>
components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleTest.java:36:
> assertEquals(URL, activity.getUrl());
> Will there be a race case where the request might not have completed when we
do
> the asserts here?

I reworked the test verify the UI.  I figure this is more like a typical
instrumentation test.

[xunjieli, 2015-10-30 14:42:10]

On 2015/10/30 14:08:46, pauljensen wrote:
> On 2015/10/29 22:13:57, xunjieli wrote:
> >
>
https://codereview.chromium.org/1419033005/diff/20001/components/cronet/andro...
> > File
> >
>
components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleTest.java
> > (right):
> > 
> >
>
https://codereview.chromium.org/1419033005/diff/20001/components/cronet/andro...
> >
>
components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleTest.java:36:
> > assertEquals(URL, activity.getUrl());
> > Will there be a race case where the request might not have completed when we
> do
> > the asserts here?
> 
> I reworked the test verify the UI.  I figure this is more like a typical
> instrumentation test.

lgtm! Looks like it does the right job.

[pauljensen, 2015-10-30 15:09:47]

The CQ bit was checked by pauljensen@chromium.org

[commit-bot: I haz the power, 2015-10-30 15:10:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419033005/30001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419033005/30001

[commit-bot: I haz the power, 2015-10-30 15:22:49]

Committed patchset #3 (id:30001)

[commit-bot: I haz the power, 2015-10-30 15:23:44]

Patchset 3 (id:??) landed as
https://crrev.com/3c55da5faa5874d54f0ffa5e63b0dc6269a58990
Cr-Commit-Position: refs/heads/master@{#357107}