Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Unified Diff: components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java

Issue 1419033005: [Cronet] Remove CriteriaHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rework CronetSamepleTest Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java
diff --git a/components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java b/components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java
index ea8906170672eb1ab2a62622a09166fe4e65440b..fc2f6a17ae16109b235791062411a2c547f11876 100644
--- a/components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java
+++ b/components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java
@@ -39,8 +39,6 @@ public class CronetSampleActivity extends Activity {
private CronetEngine mCronetEngine;
private String mUrl;
- private boolean mLoading = false;
- private int mHttpStatusCode = 0;
private TextView mResultText;
private TextView mReceiveDataText;
@@ -79,16 +77,14 @@ public class CronetSampleActivity extends Activity {
@Override
public void onSucceeded(UrlRequest request, UrlResponseInfo info) {
- mHttpStatusCode = info.getHttpStatusCode();
- Log.i(TAG, "****** Request Completed, status code is " + mHttpStatusCode
+ Log.i(TAG, "****** Request Completed, status code is " + info.getHttpStatusCode()
+ ", total received bytes is " + info.getReceivedBytesCount());
final String receivedData = mBytesReceived.toString();
final String url = info.getUrl();
- final String text = "Completed " + url + " (" + mHttpStatusCode + ")";
+ final String text = "Completed " + url + " (" + info.getHttpStatusCode() + ")";
CronetSampleActivity.this.runOnUiThread(new Runnable() {
public void run() {
- mLoading = false;
mResultText.setText(text);
mReceiveDataText.setText(receivedData);
promptForURL(url);
@@ -104,7 +100,6 @@ public class CronetSampleActivity extends Activity {
final String text = "Failed " + mUrl + " (" + error.getMessage() + ")";
CronetSampleActivity.this.runOnUiThread(new Runnable() {
public void run() {
- mLoading = false;
mResultText.setText(text);
promptForURL(url);
}
@@ -208,7 +203,6 @@ public class CronetSampleActivity extends Activity {
private void startWithURL(String url, String postData) {
Log.i(TAG, "Cronet started: " + url);
mUrl = url;
- mLoading = false;
Executor executor = Executors.newSingleThreadExecutor();
UrlRequest.Callback callback = new SimpleUrlRequestCallback();
@@ -217,27 +211,6 @@ public class CronetSampleActivity extends Activity {
builder.build().start();
}
- /**
- * This method is used in testing.
- */
- public String getUrl() {
- return mUrl;
- }
-
- /**
- * This method is used in testing.
- */
- public boolean isLoading() {
- return mLoading;
- }
-
- /**
- * This method is used in testing.
- */
- public int getHttpStatusCode() {
- return mHttpStatusCode;
- }
-
private void startNetLog() {
mCronetEngine.startNetLogToFile(
Environment.getExternalStorageDirectory().getPath() + "/cronet_sample_netlog.json",

Powered by Google App Engine
This is Rietveld 408576698