Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Issue 1418993002: [turbofan] Unify NamedAccess and PropertyAccess operator parameters. (Closed)

Created:
5 years, 2 months ago by Benedikt Meurer
Modified:
5 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Unify NamedAccess and PropertyAccess operator parameters. Use a unified NamedAccess operator parameter for both JSLoadNamed and JSStoreNamed, and similar use PropertyAccess for both JSLoadProperty and JSStoreProperty. Committed: https://crrev.com/bb20d7aea011962727a2558b6fbc0705a02946d0 Cr-Commit-Position: refs/heads/master@{#31456}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -208 lines) Patch
M src/compiler/ast-graph-builder.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-operator.h View 3 chunks +34 lines, -93 lines 0 comments Download
M src/compiler/js-operator.cc View 3 chunks +39 lines, -101 lines 0 comments Download
M src/compiler/js-type-feedback.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/js-type-feedback-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
Hey Jaro, Here's a simple cleanup for the operators. Please take a look. Thanks, Benedikt
5 years, 2 months ago (2015-10-22 07:29:25 UTC) #2
Jarin
lgtm
5 years, 2 months ago (2015-10-22 08:19:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418993002/1
5 years, 2 months ago (2015-10-22 08:19:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-22 08:46:58 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 08:48:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb20d7aea011962727a2558b6fbc0705a02946d0
Cr-Commit-Position: refs/heads/master@{#31456}

Powered by Google App Engine
This is Rietveld 408576698