Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1418963006: Remove check_git_config.py DEPS hook. (Closed)

Created:
5 years, 1 month ago by Vadim Sh.
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove check_git_config.py DEPS hook. It is not very useful anymore. R=kjellander@chromium.org, iannucci@chromium.org BUG= Committed: https://crrev.com/45de1e66fecbd2d12a3e2a2fa27486edaa421b5a Cr-Commit-Position: refs/heads/master@{#357940}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M DEPS View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Vadim Sh.
5 years, 1 month ago (2015-11-04 22:19:25 UTC) #2
kjellander_chromium
lgtm, but I don't know if there's some edge case that may still have use ...
5 years, 1 month ago (2015-11-04 22:44:24 UTC) #4
Vadim Sh.
I doubt it...
5 years, 1 month ago (2015-11-04 22:49:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418963006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418963006/1
5 years, 1 month ago (2015-11-04 22:49:42 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-05 00:20:25 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 00:21:17 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/45de1e66fecbd2d12a3e2a2fa27486edaa421b5a
Cr-Commit-Position: refs/heads/master@{#357940}

Powered by Google App Engine
This is Rietveld 408576698