Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 141893007: Remove V8Utilities (Closed)

Created:
6 years, 10 months ago by haraken
Modified:
6 years, 9 months ago
CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, Nils Barth (inactive), caseq+blink_chromium.org, Nate Chapin, arv+blink, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, devtools-reviews_chromium.org, loislo+blink_chromium.org, sof, lushnikov+blink_chromium.org, kinuko, eustas+blink_chromium.org, paulirish+reviews_chromium.org, kojih, jsbell+bindings_chromium.org, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, Inactive
Visibility:
Public.

Description

Remove V8Utilities - This CL moves extractTransferables() from V8Utilities to SerializedScriptValue, since the method is related to SerializedScriptValue. - Then removes V8Utilities.{h,cpp} BUG=339037 R=jochen@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168375

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -196 lines) Patch
M Source/bindings/bindings.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/bindings/v8/DOMWrapperMap.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/v8/Dictionary.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/v8/IDBBindingUtilitiesTest.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/v8/ScriptCallStackFactory.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/v8/ScriptFunctionCall.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/v8/ScriptState.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/v8/ScriptWrappable.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/v8/SerializedScriptValue.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M Source/bindings/v8/SerializedScriptValue.cpp View 1 2 2 chunks +51 lines, -1 line 0 comments Download
M Source/bindings/v8/V8AbstractEventListener.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/v8/V8Callback.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/v8/V8MutationCallback.h View 1 chunk +0 lines, -1 line 0 comments Download
D Source/bindings/v8/V8Utilities.h View 1 chunk +0 lines, -59 lines 0 comments Download
D Source/bindings/v8/V8Utilities.cpp View 1 1 chunk +0 lines, -104 lines 0 comments Download
M Source/bindings/v8/V8ValueCache.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/v8/custom/V8BlobCustomHelpers.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/v8/custom/V8CryptoCustom.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/v8/custom/V8CustomXPathNSResolver.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/v8/custom/V8DedicatedWorkerGlobalScopeCustom.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8FormDataCustom.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/v8/custom/V8GeolocationCustom.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/v8/custom/V8MessageChannelCustom.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/v8/custom/V8MessagePortCustom.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8MutationObserverCustom.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/v8/custom/V8WindowCustom.cpp View 1 2 chunks +1 line, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8WorkerCustom.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8WorkerGlobalScopeCustom.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/EmptyNodeList.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/MutationObserver.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/InjectedScriptHost.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGMatrixTearOff.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/quota/DeprecatedStorageInfo.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/quota/DeprecatedStorageQuota.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebDevToolsFrontendImpl.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
haraken
PTAL
6 years, 10 months ago (2014-01-31 02:33:54 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 10 months ago (2014-01-31 08:08:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/141893007/1
6 years, 10 months ago (2014-01-31 08:57:51 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=24951
6 years, 10 months ago (2014-01-31 11:48:30 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 11:48:32 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 11:48:36 UTC) #6
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 9 months ago (2014-03-03 13:16:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/141893007/200001
6 years, 9 months ago (2014-03-03 13:16:33 UTC) #8
haraken
I noticed that this CL hasn't yet been landed. There was little conflict, so let ...
6 years, 9 months ago (2014-03-03 13:16:44 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 14:07:50 UTC) #10
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) blink_heap_unittests, blink_platform_unittests, webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, ...
6 years, 9 months ago (2014-03-03 14:07:51 UTC) #11
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 9 months ago (2014-03-04 05:02:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/141893007/220001
6 years, 9 months ago (2014-03-04 05:03:07 UTC) #13
haraken
6 years, 9 months ago (2014-03-04 10:53:56 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 manually as r168375 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698