Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: Source/bindings/v8/V8ValueCache.cpp

Issue 141893007: Remove V8Utilities (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/bindings/v8/V8Utilities.cpp ('k') | Source/bindings/v8/custom/V8BlobCustomHelpers.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' 13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
14 * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, 14 * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
15 * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
17 * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR 17 * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
18 * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF 18 * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
19 * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS 19 * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
20 * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN 20 * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
21 * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) 21 * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
22 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF 22 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
23 * THE POSSIBILITY OF SUCH DAMAGE. 23 * THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #include "config.h" 26 #include "config.h"
27 #include "bindings/v8/V8ValueCache.h" 27 #include "bindings/v8/V8ValueCache.h"
28 28
29 #include "bindings/v8/V8Binding.h" 29 #include "bindings/v8/V8Binding.h"
30 #include "bindings/v8/V8Utilities.h"
31 #include "wtf/text/StringHash.h" 30 #include "wtf/text/StringHash.h"
32 31
33 namespace WebCore { 32 namespace WebCore {
34 33
35 static v8::Local<v8::String> makeExternalString(const String& string, v8::Isolat e* isolate) 34 static v8::Local<v8::String> makeExternalString(const String& string, v8::Isolat e* isolate)
36 { 35 {
37 if (string.is8Bit()) { 36 if (string.is8Bit()) {
38 WebCoreStringResource8* stringResource = new WebCoreStringResource8(stri ng); 37 WebCoreStringResource8* stringResource = new WebCoreStringResource8(stri ng);
39 v8::Local<v8::String> newString = v8::String::NewExternal(isolate, strin gResource); 38 v8::Local<v8::String> newString = v8::String::NewExternal(isolate, strin gResource);
40 if (newString.IsEmpty()) 39 if (newString.IsEmpty())
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 StringCache* stringCache = V8PerIsolateData::from(data.GetIsolate())->string Cache(); 107 StringCache* stringCache = V8PerIsolateData::from(data.GetIsolate())->string Cache();
109 stringCache->m_lastStringImpl = nullptr; 108 stringCache->m_lastStringImpl = nullptr;
110 stringCache->m_lastV8String.clear(); 109 stringCache->m_lastV8String.clear();
111 ASSERT(stringCache->m_stringCache.contains(data.GetParameter())); 110 ASSERT(stringCache->m_stringCache.contains(data.GetParameter()));
112 stringCache->m_stringCache.get(data.GetParameter()).dispose(); 111 stringCache->m_stringCache.get(data.GetParameter()).dispose();
113 stringCache->m_stringCache.remove(data.GetParameter()); 112 stringCache->m_stringCache.remove(data.GetParameter());
114 data.GetParameter()->deref(); 113 data.GetParameter()->deref();
115 } 114 }
116 115
117 } // namespace WebCore 116 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/V8Utilities.cpp ('k') | Source/bindings/v8/custom/V8BlobCustomHelpers.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698