Issue 14189011: Remove instant confirmation dialog that is displayed the first time the instant checkbox is clicked.

Issue 14189011: Remove instant confirmation dialog that is displayed the first time the instant checkbox is clicked. (Closed)

Created:
7 years, 8 months ago by robertshield

Modified:
7 years, 8 months ago

Reviewers:
James Hawkins, sreeram, akalin

CC:
chromium-reviews, dbeam+watch-options_chromium.org, melevin, dhollowa+watch_chromium.org, dougw+watch_chromium.org, gideonwald, sreeram, dominich, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove instant confirmation dialog that is displayed the first time the instant checkbox is clicked. BUG=231092 TEST=Delete profile, go to settings, turn on instant, observe that no dialog appears. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195625

Patch Set 1 #

Patch Set 2 : Remove parenthetical warning strings from instant checkbox label. #

Patch Set 3 : Remove prefs::InstantConfirmDialogShown #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -84 lines)			Patch
M	chrome/app/chromium_strings.grd	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/app/generated_resources.grd	View		1 chunk	+2 lines, -8 lines	0 comments	Download
M	chrome/app/google_chrome_strings.grd	View		1 chunk	+0 lines, -3 lines	0 comments	Download
D	chrome/browser/resources/options/instant_confirm_overlay.css	View		1 chunk	+0 lines, -16 lines	0 comments	Download
D	chrome/browser/resources/options/instant_confirm_overlay.html	View		1 chunk	+0 lines, -17 lines	0 comments	Download
M	chrome/browser/resources/options/options.html	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/options/options.js	View		1 chunk	+0 lines, -11 lines	0 comments	Download
M	chrome/browser/search/search.cc	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/test/integration/two_client_preferences_sync_test.cc	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/options/browser_options_handler.cc	View	1	3 chunks	+1 line, -5 lines	0 comments	Download
M	chrome/common/pref_names.h	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/pref_names.cc	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/common/url_constants.h	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/common/url_constants.cc	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

sreeram

Could you also remove prefs::kInstantConfirmDialogShown and all references to it? Thanks!

7 years, 8 months ago (2013-04-19 21:10:01 UTC) #2

robertshield

On 2013/04/19 21:10:01, sreeram wrote: > Could you also remove prefs::kInstantConfirmDialogShown and all references to ...

7 years, 8 months ago (2013-04-19 21:46:59 UTC) #3

robertshield

OWNERS request, PTAL: +akalin for chrome\browser\sync\test\integration\two_client_preferences_sync_test.cc +jhawkins for everything else

7 years, 8 months ago (2013-04-20 15:17:49 UTC) #5

James Hawkins

On 2013/04/20 15:17:49, robertshield wrote: > OWNERS request, PTAL: > +akalin for > chrome\browser\sync\test\integration\two_client_preferences_sync_test.cc > ...

7 years, 8 months ago (2013-04-22 17:01:32 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/14189011/9001

7 years, 8 months ago (2013-04-22 19:01:27 UTC) #8

Message was sent while issue was closed.

Change committed as 195625

Expand Messages | Collapse Messages