Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: chrome/browser/ui/webui/options/browser_options_handler.cc

Issue 14189011: Remove instant confirmation dialog that is displayed the first time the instant checkbox is clicked. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove prefs::InstantConfirmDialogShown Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/options/browser_options_handler.h" 5 #include "chrome/browser/ui/webui/options/browser_options_handler.h"
6 6
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
230 { "fontSizeLabelLarge", IDS_OPTIONS_FONT_SIZE_LABEL_LARGE }, 230 { "fontSizeLabelLarge", IDS_OPTIONS_FONT_SIZE_LABEL_LARGE },
231 { "fontSizeLabelMedium", IDS_OPTIONS_FONT_SIZE_LABEL_MEDIUM }, 231 { "fontSizeLabelMedium", IDS_OPTIONS_FONT_SIZE_LABEL_MEDIUM },
232 { "fontSizeLabelSmall", IDS_OPTIONS_FONT_SIZE_LABEL_SMALL }, 232 { "fontSizeLabelSmall", IDS_OPTIONS_FONT_SIZE_LABEL_SMALL },
233 { "fontSizeLabelVeryLarge", IDS_OPTIONS_FONT_SIZE_LABEL_VERY_LARGE }, 233 { "fontSizeLabelVeryLarge", IDS_OPTIONS_FONT_SIZE_LABEL_VERY_LARGE },
234 { "fontSizeLabelVerySmall", IDS_OPTIONS_FONT_SIZE_LABEL_VERY_SMALL }, 234 { "fontSizeLabelVerySmall", IDS_OPTIONS_FONT_SIZE_LABEL_VERY_SMALL },
235 { "hideAdvancedSettings", IDS_SETTINGS_HIDE_ADVANCED_SETTINGS }, 235 { "hideAdvancedSettings", IDS_SETTINGS_HIDE_ADVANCED_SETTINGS },
236 { "homePageNtp", IDS_OPTIONS_HOMEPAGE_NTP }, 236 { "homePageNtp", IDS_OPTIONS_HOMEPAGE_NTP },
237 { "homePageShowHomeButton", IDS_OPTIONS_TOOLBAR_SHOW_HOME_BUTTON }, 237 { "homePageShowHomeButton", IDS_OPTIONS_TOOLBAR_SHOW_HOME_BUTTON },
238 { "homePageUseNewTab", IDS_OPTIONS_HOMEPAGE_USE_NEWTAB }, 238 { "homePageUseNewTab", IDS_OPTIONS_HOMEPAGE_USE_NEWTAB },
239 { "homePageUseURL", IDS_OPTIONS_HOMEPAGE_USE_URL }, 239 { "homePageUseURL", IDS_OPTIONS_HOMEPAGE_USE_URL },
240 { "instantConfirmMessage", IDS_INSTANT_OPT_IN_MESSAGE },
241 { "importData", IDS_OPTIONS_IMPORT_DATA_BUTTON }, 240 { "importData", IDS_OPTIONS_IMPORT_DATA_BUTTON },
242 { "improveBrowsingExperience", IDS_OPTIONS_IMPROVE_BROWSING_EXPERIENCE }, 241 { "improveBrowsingExperience", IDS_OPTIONS_IMPROVE_BROWSING_EXPERIENCE },
243 { "languageAndSpellCheckSettingsButton", 242 { "languageAndSpellCheckSettingsButton",
244 IDS_OPTIONS_SETTINGS_LANGUAGE_AND_INPUT_SETTINGS }, 243 IDS_OPTIONS_SETTINGS_LANGUAGE_AND_INPUT_SETTINGS },
245 { "linkDoctorPref", IDS_OPTIONS_LINKDOCTOR_PREF }, 244 { "linkDoctorPref", IDS_OPTIONS_LINKDOCTOR_PREF },
246 { "manageAutofillSettings", IDS_OPTIONS_MANAGE_AUTOFILL_SETTINGS_LINK }, 245 { "manageAutofillSettings", IDS_OPTIONS_MANAGE_AUTOFILL_SETTINGS_LINK },
247 { "managePasswords", IDS_OPTIONS_PASSWORDS_MANAGE_PASSWORDS_LINK }, 246 { "managePasswords", IDS_OPTIONS_PASSWORDS_MANAGE_PASSWORDS_LINK },
248 { "managedUsersSectionTitle", IDS_OPTIONS_MANAGED_USERS_SECTION_TITLE }, 247 { "managedUsersSectionTitle", IDS_OPTIONS_MANAGED_USERS_SECTION_TITLE },
249 { "networkPredictionEnabledDescription", 248 { "networkPredictionEnabledDescription",
250 IDS_NETWORK_PREDICTION_ENABLED_DESCRIPTION }, 249 IDS_NETWORK_PREDICTION_ENABLED_DESCRIPTION },
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
404 IDS_SETTINGS_APP_LAUNCHER_PRODUCT_NAME }, 403 IDS_SETTINGS_APP_LAUNCHER_PRODUCT_NAME },
405 { "proxiesLabelSystem", IDS_OPTIONS_SYSTEM_PROXIES_LABEL, 404 { "proxiesLabelSystem", IDS_OPTIONS_SYSTEM_PROXIES_LABEL,
406 IDS_SETTINGS_APP_LAUNCHER_PRODUCT_NAME }, 405 IDS_SETTINGS_APP_LAUNCHER_PRODUCT_NAME },
407 }; 406 };
408 DictionaryValue* app_values = NULL; 407 DictionaryValue* app_values = NULL;
409 CHECK(values->GetDictionary(kSettingsAppKey, &app_values)); 408 CHECK(values->GetDictionary(kSettingsAppKey, &app_values));
410 RegisterStrings(app_values, app_resources, arraysize(app_resources)); 409 RegisterStrings(app_values, app_resources, arraysize(app_resources));
411 #endif 410 #endif
412 411
413 RegisterStrings(values, resources, arraysize(resources)); 412 RegisterStrings(values, resources, arraysize(resources));
414 RegisterTitle(values, "instantConfirmOverlay", IDS_INSTANT_OPT_IN_TITLE);
415 RegisterTitle(values, "doNotTrackConfirmOverlay", 413 RegisterTitle(values, "doNotTrackConfirmOverlay",
416 IDS_OPTIONS_ENABLE_DO_NOT_TRACK_BUBBLE_TITLE); 414 IDS_OPTIONS_ENABLE_DO_NOT_TRACK_BUBBLE_TITLE);
417 RegisterTitle(values, "spellingConfirmOverlay", 415 RegisterTitle(values, "spellingConfirmOverlay",
418 IDS_CONTENT_CONTEXT_SPELLING_ASK_GOOGLE); 416 IDS_CONTENT_CONTEXT_SPELLING_ASK_GOOGLE);
419 RegisterCloudPrintValues(values); 417 RegisterCloudPrintValues(values);
420 418
421 values->SetString("syncLearnMoreURL", chrome::kSyncLearnMoreURL); 419 values->SetString("syncLearnMoreURL", chrome::kSyncLearnMoreURL);
422 string16 omnibox_url = ASCIIToUTF16(chrome::kOmniboxLearnMoreURL); 420 string16 omnibox_url = ASCIIToUTF16(chrome::kOmniboxLearnMoreURL);
423 values->SetString( 421 values->SetString(
424 "defaultSearchGroupLabel", 422 "defaultSearchGroupLabel",
425 l10n_util::GetStringFUTF16(IDS_SEARCH_PREF_EXPLANATION, omnibox_url)); 423 l10n_util::GetStringFUTF16(IDS_SEARCH_PREF_EXPLANATION, omnibox_url));
426 424
427 std::string instant_pref_name = chrome::GetInstantPrefName(); 425 std::string instant_pref_name = chrome::GetInstantPrefName();
428 int instant_message_id = instant_pref_name == prefs::kInstantEnabled ? 426 int instant_message_id = instant_pref_name == prefs::kInstantEnabled ?
429 IDS_INSTANT_PREF_WITH_WARNING : IDS_INSTANT_EXTENDED_PREF_WITH_WARNING; 427 IDS_INSTANT_PREF_WITH_WARNING : IDS_INSTANT_EXTENDED_PREF_WITH_WARNING;
430 string16 instant_learn_more_url = ASCIIToUTF16(chrome::kInstantLearnMoreURL);
431 values->SetString("instant_enabled", instant_pref_name); 428 values->SetString("instant_enabled", instant_pref_name);
432 values->SetString( 429 values->SetString(
433 "instantPrefAndWarning", 430 "instantPrefAndWarning",
434 l10n_util::GetStringFUTF16(instant_message_id, instant_learn_more_url)); 431 l10n_util::GetStringUTF16(instant_message_id));
435 values->SetString("instantLearnMoreLink", instant_learn_more_url);
436 432
437 #if defined(OS_CHROMEOS) 433 #if defined(OS_CHROMEOS)
438 const chromeos::User* user = chromeos::UserManager::Get()->GetLoggedInUser(); 434 const chromeos::User* user = chromeos::UserManager::Get()->GetLoggedInUser();
439 values->SetString("username", user ? user->email() : std::string()); 435 values->SetString("username", user ? user->email() : std::string());
440 #endif 436 #endif
441 437
442 // Pass along sync status early so it will be available during page init. 438 // Pass along sync status early so it will be available during page init.
443 values->Set("syncData", GetSyncStateDictionary().release()); 439 values->Set("syncData", GetSyncStateDictionary().release());
444 440
445 values->SetString("privacyLearnMoreURL", chrome::kPrivacyLearnMoreURL); 441 values->SetString("privacyLearnMoreURL", chrome::kPrivacyLearnMoreURL);
(...skipping 1085 matching lines...) Expand 10 before | Expand all | Expand 10 after
1531 base::FundamentalValue disabled(profile_pref_registrar_.IsManaged() || 1527 base::FundamentalValue disabled(profile_pref_registrar_.IsManaged() ||
1532 is_extension_controlled); 1528 is_extension_controlled);
1533 base::FundamentalValue extension_controlled(is_extension_controlled); 1529 base::FundamentalValue extension_controlled(is_extension_controlled);
1534 web_ui()->CallJavascriptFunction("BrowserOptions.setupProxySettingsSection", 1530 web_ui()->CallJavascriptFunction("BrowserOptions.setupProxySettingsSection",
1535 disabled, extension_controlled); 1531 disabled, extension_controlled);
1536 1532
1537 #endif // !defined(OS_CHROMEOS) 1533 #endif // !defined(OS_CHROMEOS)
1538 } 1534 }
1539 1535
1540 } // namespace options 1536 } // namespace options
OLDNEW
« no previous file with comments | « chrome/browser/sync/test/integration/two_client_preferences_sync_test.cc ('k') | chrome/common/pref_names.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698