[chromedriver] Fix bug in command for GetElementValueOfCSSProperty.

chrome/test/chromedriver/element_util.cc

Index: chrome/test/chromedriver/element_util.cc
diff --git a/chrome/test/chromedriver/element_util.cc b/chrome/test/chromedriver/element_util.cc
index b230e781fdf6f4ebd73dc988c3b48954bcbb8afd..a3c3c42fe7c352b39e85def181150ffbaa4b2d04 100644
--- a/chrome/test/chromedriver/element_util.cc
+++ b/chrome/test/chromedriver/element_util.cc
@@ -158,26 +158,6 @@ Status ScrollElementRegionIntoViewHelper(
   return Status(kOk);
 }
 
-Status GetElementEffectiveStyle(
-    const std::string& frame,
-    WebView* web_view,
-    const std::string& element_id,
-    const std::string& property,
-    std::string* value) {
-  base::ListValue args;
-  args.Append(CreateElement(element_id));
-  args.AppendString(property);
-  scoped_ptr<base::Value> result;
-  Status status = web_view->CallFunction(
-      frame, webdriver::atoms::asString(webdriver::atoms::GET_EFFECTIVE_STYLE),
-      args, &result);
-  if (status.IsError())
-    return status;
-  if (!result->GetAsString(value))
-    return Status(kUnknownError, "fail to parse value of GET_EFFECTIVE_STYLE");
-  return Status(kOk);
-}
-
 Status GetElementBorder(
     const std::string& frame,
     WebView* web_view,
@@ -340,6 +320,26 @@ Status GetElementClickableLocation(
   return Status(kOk);
 }
 
+Status GetElementEffectiveStyle(
+    const std::string& frame,

[kkania, 2013/04/18 00:38:52]

i think it would make sense for the webview to be the first arg, unless it's
already been established convention that frame does

[chrisgao (Use stgao instead), 2013/04/18 01:39:48]

Fix in the established convention here.

+    WebView* web_view,
+    const std::string& element_id,
+    const std::string& property,
+    std::string* value) {
+  base::ListValue args;
+  args.Append(CreateElement(element_id));
+  args.AppendString(property);
+  scoped_ptr<base::Value> result;
+  Status status = web_view->CallFunction(
+      frame, webdriver::atoms::asString(webdriver::atoms::GET_EFFECTIVE_STYLE),
+      args, &result);
+  if (status.IsError())
+    return status;
+  if (!result->GetAsString(value))
+    return Status(kUnknownError, "fail to parse value of GET_EFFECTIVE_STYLE");

[kkania, 2013/04/18 00:38:52]

failed

[chrisgao (Use stgao instead), 2013/04/18 01:39:48]

Done.

+  return Status(kOk);
+}
+
 Status GetElementRegion(
     Session* session,
     WebView* web_view,