[chromedriver] Fix bug in command for GetElementValueOfCSSProperty.

chrome/test/chromedriver/element_util.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/chromedriver/element_util.h"
 
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/threading/platform_thread.h"
@@ skipping 140 matching lines @@
     WebPoint middle = tmp_location;
     middle.Offset(region.Width() / 2, region.Height() / 2);
     status = VerifyElementClickable(frame, web_view, element_id, middle);
     if (status.IsError())
       return status;
   }
   *location = tmp_location;
   return Status(kOk);
 }
 
-Status GetElementEffectiveStyle(
-    const std::string& frame,
-    WebView* web_view,
-    const std::string& element_id,
-    const std::string& property,
-    std::string* value) {
-  base::ListValue args;
-  args.Append(CreateElement(element_id));
-  args.AppendString(property);
-  scoped_ptr<base::Value> result;
-  Status status = web_view->CallFunction(
-      frame, webdriver::atoms::asString(webdriver::atoms::GET_EFFECTIVE_STYLE),
-      args, &result);
-  if (status.IsError())
-    return status;
-  if (!result->GetAsString(value))
-    return Status(kUnknownError, "fail to parse value of GET_EFFECTIVE_STYLE");
-  return Status(kOk);
-}
-
 Status GetElementBorder(
     const std::string& frame,
     WebView* web_view,
     const std::string& element_id,
     int* border_left,
     int* border_top) {
   std::string border_left_str;
   Status status = GetElementEffectiveStyle(
       frame, web_view, element_id, "border-left-width", &border_left_str);
   if (status.IsError())
@@ skipping 142 matching lines @@
 
   status = ScrollElementRegionIntoView(
       session, web_view, element_id, rect,
       true /* center */, true /* verify_clickable */, location);
   if (status.IsError())
     return status;
   location->Offset(rect.Width() / 2, rect.Height() / 2);
   return Status(kOk);
 }
 
+Status GetElementEffectiveStyle(
+    const std::string& frame,

[kkania, 2013/04/18 00:38:52]

i think it would make sense for the webview to be the first arg, unless it's
already been established convention that frame does

[chrisgao (Use stgao instead), 2013/04/18 01:39:48]

Fix in the established convention here.

+    WebView* web_view,
+    const std::string& element_id,
+    const std::string& property,
+    std::string* value) {
+  base::ListValue args;
+  args.Append(CreateElement(element_id));
+  args.AppendString(property);
+  scoped_ptr<base::Value> result;
+  Status status = web_view->CallFunction(
+      frame, webdriver::atoms::asString(webdriver::atoms::GET_EFFECTIVE_STYLE),
+      args, &result);
+  if (status.IsError())
+    return status;
+  if (!result->GetAsString(value))
+    return Status(kUnknownError, "fail to parse value of GET_EFFECTIVE_STYLE");

[kkania, 2013/04/18 00:38:52]

failed

[chrisgao (Use stgao instead), 2013/04/18 01:39:48]

Done.

+  return Status(kOk);
+}
+
 Status GetElementRegion(
     Session* session,
     WebView* web_view,
     const std::string& element_id,
     WebRect* rect) {
   base::ListValue args;
   args.Append(CreateElement(element_id));
   scoped_ptr<base::Value> result;
   Status status = web_view->CallFunction(
       session->GetCurrentFrameId(), kGetElementRegionScript, args, &result);
@@ skipping 209 matching lines @@
     status = ScrollElementRegionIntoViewHelper(
         rit->parent_frame_id, web_view, frame_element_id,
         WebRect(region_offset, region_size),
         center, verify_clickable, &region_offset);
     if (status.IsError())
       return status;
   }
   *location = region_offset;
   return Status(kOk);
 }